Message ID | 20170111143712.510147-1-arnd@arndb.de |
---|---|
State | New |
Headers | show |
On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Since gpio_dev->hwbank_num is now a variable, the compiler cannot > figure out if pin_num is initialized at all: > > drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': > drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] > for (; i < pin_num; i++) { > ^~~ > drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] > > This adds a 'default' statement to make that case well-defined. > > Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch. Do you feel this patch needs to be taken ? Thanks, Shyam On 1/12/2017 1:19 PM, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> Since gpio_dev->hwbank_num is now a variable, the compiler cannot >> figure out if pin_num is initialized at all: >> >> drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': >> drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] >> for (; i < pin_num; i++) { >> ^~~ >> drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] >> >> This adds a 'default' statement to make that case well-defined. >> >> Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Patch applied. > > Yours, > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 7b95c1886f7b..9495e6eb76d1 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -206,6 +206,8 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) i = 192; pin_num = AMD_GPIO_PINS_BANK3 + i; break; + default: + return; } for (; i < pin_num; i++) { seq_printf(s, "pin%d\t", i);
Since gpio_dev->hwbank_num is now a variable, the compiler cannot figure out if pin_num is initialized at all: drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] for (; i < pin_num; i++) { ^~~ drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds a 'default' statement to make that case well-defined. Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/pinctrl/pinctrl-amd.c | 2 ++ 1 file changed, 2 insertions(+)