diff mbox

tools: gpio add .gitignore for generated files

Message ID 20170105213236.15562-5-shuahkh@osg.samsung.com
State New
Headers show

Commit Message

Shuah Khan Jan. 5, 2017, 9:32 p.m. UTC
Add .gitignore for generated files.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/gpio/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/gpio/.gitignore

Comments

Linus Walleij Jan. 10, 2017, 9:29 a.m. UTC | #1
On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:

> Add .gitignore for generated files.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  tools/gpio/.gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 tools/gpio/.gitignore
>
> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
> new file mode 100644
> index 0000000..767ad24
> --- /dev/null
> +++ b/tools/gpio/.gitignore
> @@ -0,0 +1,4 @@
> +gpio-event-mon
> +gpio-hammer
> +lsgpio
> +include

I understand the first three.

But "include"?
How did you produce that?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shuah Khan Jan. 10, 2017, 2:07 p.m. UTC | #2
On 01/10/2017 02:29 AM, Linus Walleij wrote:
> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> 
>> Add .gitignore for generated files.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  tools/gpio/.gitignore | 4 ++++
>>  1 file changed, 4 insertions(+)
>>  create mode 100644 tools/gpio/.gitignore
>>
>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>> new file mode 100644
>> index 0000000..767ad24
>> --- /dev/null
>> +++ b/tools/gpio/.gitignore
>> @@ -0,0 +1,4 @@
>> +gpio-event-mon
>> +gpio-hammer
>> +lsgpio
>> +include
> 
> I understand the first three.
> 
> But "include"?
> How did you produce that?
> 
> Yours,
> Linus Walleij
> 

I saw this after building selftests. gpio selftests Makefile installs
headres. "make kselftest" should reproduce the problem. This following
does an header install from tools/testing/selftests/gpio/Makefile

../../../../usr/include/linux/gpio.h:
        make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 11, 2017, 3:19 p.m. UTC | #3
On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>
>>> Add .gitignore for generated files.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>>  tools/gpio/.gitignore | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>  create mode 100644 tools/gpio/.gitignore
>>>
>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>> new file mode 100644
>>> index 0000000..767ad24
>>> --- /dev/null
>>> +++ b/tools/gpio/.gitignore
>>> @@ -0,0 +1,4 @@
>>> +gpio-event-mon
>>> +gpio-hammer
>>> +lsgpio
>>> +include
>>
>> I understand the first three.
>>
>> But "include"?
>> How did you produce that?
>>
>> Yours,
>> Linus Walleij
>>
>
> I saw this after building selftests. gpio selftests Makefile installs
> headres. "make kselftest" should reproduce the problem. This following
> does an header install from tools/testing/selftests/gpio/Makefile
>
> ../../../../usr/include/linux/gpio.h:
>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

That seems like a bug.

I applied the patch removing the ignore line for include,
I think we should see this until we figured out what we do wrong.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shuah Khan Jan. 11, 2017, 4:02 p.m. UTC | #4
On 01/11/2017 08:19 AM, Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>>
>>>> Add .gitignore for generated files.
>>>>
>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>> ---
>>>>  tools/gpio/.gitignore | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>  create mode 100644 tools/gpio/.gitignore
>>>>
>>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>>> new file mode 100644
>>>> index 0000000..767ad24
>>>> --- /dev/null
>>>> +++ b/tools/gpio/.gitignore
>>>> @@ -0,0 +1,4 @@
>>>> +gpio-event-mon
>>>> +gpio-hammer
>>>> +lsgpio
>>>> +include
>>>
>>> I understand the first three.
>>>
>>> But "include"?
>>> How did you produce that?
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>> I saw this after building selftests. gpio selftests Makefile installs
>> headres. "make kselftest" should reproduce the problem. This following
>> does an header install from tools/testing/selftests/gpio/Makefile
>>
>> ../../../../usr/include/linux/gpio.h:
>>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
> 
> That seems like a bug.
> 
> I applied the patch removing the ignore line for include,
> I think we should see this until we figured out what we do wrong.
> 
> Yours,
> Linus Walleij
> 


Sounds good.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
new file mode 100644
index 0000000..767ad24
--- /dev/null
+++ b/tools/gpio/.gitignore
@@ -0,0 +1,4 @@ 
+gpio-event-mon
+gpio-hammer
+lsgpio
+include