| Message ID | 20161106185322.28372-1-pbrobinson@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Sun, Nov 6, 2016 at 7:53 PM, Peter Robinson <pbrobinson@gmail.com> wrote: > The GPIO_EM is part of the Renesas SoCs so depend on the arch. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> What about also enabling COMPILE_TEST? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 7, 2016 at 9:01 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Nov 6, 2016 at 7:53 PM, Peter Robinson <pbrobinson@gmail.com> wrote: > >> The GPIO_EM is part of the Renesas SoCs so depend on the arch. >> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > > What about also enabling COMPILE_TEST? Happy to, never really know the rule of thumb on COMPILE_TEST, the decision to enable it always seems somewhat arbitrary (almost like it should be an option for all drivers when run in that mode as opposed to explicitly adding an option). Peter -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 7, 2016 at 10:55 AM, Peter Robinson <pbrobinson@gmail.com> wrote: > On Mon, Nov 7, 2016 at 9:01 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Sun, Nov 6, 2016 at 7:53 PM, Peter Robinson <pbrobinson@gmail.com> wrote: >> >>> The GPIO_EM is part of the Renesas SoCs so depend on the arch. >>> >>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> >> What about also enabling COMPILE_TEST? > > Happy to, never really know the rule of thumb on COMPILE_TEST, the > decision to enable it always seems somewhat arbitrary (almost like it > should be an option for all drivers when run in that mode as opposed > to explicitly adding an option). I think in these patches ask: - Did it compile a lot before the change and get a lot of coverage? - Does it compile less after this change? - Then add COMPILE_TEST so we can get that coverage back when needed for test. I do understand the point of not pushing a lot of options and pointless compilation and modules in the face of everyone in the world, just that the compile farms still need to churn these drivers. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index d011cb8..76e6c80 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -171,7 +171,7 @@ config GPIO_DWAPB config GPIO_EM tristate "Emma Mobile GPIO" - depends on ARM && OF_GPIO + depends on ARCH_SHMOBILE && OF_GPIO help Say yes here to support GPIO on Renesas Emma Mobile SoCs.
The GPIO_EM is part of the Renesas SoCs so depend on the arch. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)