| Message ID | 20160831082520.25962-4-woogyom.kim@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Aug 31, 2016 at 10:25 AM, Milo Kim <woogyom.kim@gmail.com> wrote: > H3 has single PWM channel. The second PWM channel is not supported, > so the pinctrl function should be removed. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Icenowy Zheng <icenowy@aosc.xyz> > Cc: Jens Kuske <jenskuske@gmail.com> > Cc: Krzysztof Adamski <k@japko.eu> > Cc: linux-gpio@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <woogyom.kim@gmail.com> Maxime what is your opinion on this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Sep 07, 2016 at 09:41:19PM +0200, Linus Walleij wrote: > On Wed, Aug 31, 2016 at 10:25 AM, Milo Kim <woogyom.kim@gmail.com> wrote: > > > H3 has single PWM channel. The second PWM channel is not supported, > > so the pinctrl function should be removed. > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > > Cc: Chen-Yu Tsai <wens@csie.org> > > Cc: Icenowy Zheng <icenowy@aosc.xyz> > > Cc: Jens Kuske <jenskuske@gmail.com> > > Cc: Krzysztof Adamski <k@japko.eu> > > Cc: linux-gpio@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Milo Kim <woogyom.kim@gmail.com> > > Maxime what is your opinion on this patch? Chen-Yu is the Allwinner co-maintainer, so you can trust his Acked-by, but you have mine too. Maxime
On Wed, Aug 31, 2016 at 10:25 AM, Milo Kim <woogyom.kim@gmail.com> wrote: > H3 has single PWM channel. The second PWM channel is not supported, > so the pinctrl function should be removed. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Icenowy Zheng <icenowy@aosc.xyz> > Cc: Jens Kuske <jenskuske@gmail.com> > Cc: Krzysztof Adamski <k@japko.eu> > Cc: linux-gpio@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <woogyom.kim@gmail.com> Patch applied with Chen-Yu's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c index 26a2ad3..518a92d 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c @@ -60,7 +60,6 @@ static const struct sunxi_desc_pin sun8i_h3_pins[] = { SUNXI_FUNCTION(0x0, "gpio_in"), SUNXI_FUNCTION(0x1, "gpio_out"), SUNXI_FUNCTION(0x2, "sim"), /* PWREN */ - SUNXI_FUNCTION(0x3, "pwm1"), SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 6)), /* PA_EINT6 */ SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 7), SUNXI_FUNCTION(0x0, "gpio_in"),
H3 has single PWM channel. The second PWM channel is not supported, so the pinctrl function should be removed. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Icenowy Zheng <icenowy@aosc.xyz> Cc: Jens Kuske <jenskuske@gmail.com> Cc: Krzysztof Adamski <k@japko.eu> Cc: linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim <woogyom.kim@gmail.com> --- drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 1 - 1 file changed, 1 deletion(-)