From patchwork Fri Sep 25 19:07:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 522958 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 71C1E140772 for ; Sat, 26 Sep 2015 05:07:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933023AbbIYTHd (ORCPT ); Fri, 25 Sep 2015 15:07:33 -0400 Received: from mail.kernel.org ([198.145.29.136]:47638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932890AbbIYTHd (ORCPT ); Fri, 25 Sep 2015 15:07:33 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0BD920834; Fri, 25 Sep 2015 19:07:31 +0000 (UTC) Received: from tiger (unknown [70.35.39.2]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63CFC20832; Fri, 25 Sep 2015 19:07:30 +0000 (UTC) Date: Fri, 25 Sep 2015 12:07:25 -0700 From: Shawn Guo To: Markus Pargmann Cc: Adrian Alonso , linux-arm-kernel@lists.infradead.org, shawn.guo@linaro.org, linus.walleij@linaro.org, lznuaa@gmail.com, devicetree@vger.kernel.org, Frank.Li@freescale.com, nitin.garg@freescale.com, Anson.Huang@freescale.com, linux-gpio@vger.kernel.org, robh+dt@kernel.org, kernel@pengutronix.de, yibin.gong@freescale.com Subject: Re: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero Message-ID: <20150925190725.GX3529@tiger> References: <1443128043-21063-1-git-send-email-aalonso@freescale.com> <1443128043-21063-4-git-send-email-aalonso@freescale.com> <20150925104726.GJ11805@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150925104726.GJ11805@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Sep 25, 2015 at 12:47:26PM +0200, Markus Pargmann wrote: > On Thu, Sep 24, 2015 at 03:54:00PM -0500, Adrian Alonso wrote: > > Allow mux_reg offset zero to be a valid pin_id, on imx7d > > mux_conf reg offset is zero for iomuxc-lspr controller > > > > Signed-off-by: Adrian Alonso > > --- > > Changes for V2: Resend > > Changes for V3: Resend > > Changes for V4: Simplify pin_id assigment when ZERO_OFFSET_VALID is set > > Changes for V5: > > - Drop patch pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag > > - Allow mux_reg ZERO OFFSET as pin_id > > > > drivers/pinctrl/freescale/pinctrl-imx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c > > index b9c6deb..23348d8 100644 > > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > > @@ -550,7 +550,7 @@ static int imx_pinctrl_parse_groups(struct device_node *np, > > conf_reg = -1; > > } > > > > - pin_id = mux_reg ? mux_reg / 4 : conf_reg / 4; > > + pin_id = (mux_reg != -1) ? mux_reg / 4 : conf_reg / 4; > > This will break compatibility with imx35 and imx25 pinctrl drivers. They > have definitions where mux_reg can be 0x0. See imx35-pinfunc.h and > imx25-pinfunc.h: > > git grep -E "0x0+ 0x.* 0x.* 0x.* 0x.*" > > This mux_reg behaviour was not described in the DT binding > documentation. But it is used by some platforms. So even if you change > the pincfunc headers to use "-1", it would break devicetrees compiled > with earlier kernel versions. Ah, sorry, I'm screwed on the previous review. So we still need the flag ZERO_OFFSET_VALID to convert invalid 0 mux_reg to -1. @Adrian, Will the following change just work for you? Shawn --- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index d7b98ba36825..ae801ba7e226 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -542,6 +542,9 @@ static int imx_pinctrl_parse_groups(struct device_node *np, struct imx_pin_reg *pin_reg; struct imx_pin *pin = &grp->pins[i]; + if (!(info->flags & ZERO_OFFSET_VALID) && !mux_reg) + mux_reg = -1; + if (info->flags & SHARE_MUX_CONF_REG) { conf_reg = mux_reg; } else { @@ -550,7 +553,7 @@ static int imx_pinctrl_parse_groups(struct device_node *np, conf_reg = -1; } - pin_id = mux_reg ? mux_reg / 4 : conf_reg / 4; + pin_id = (mux_reg != -1) ? mux_reg / 4 : conf_reg / 4; pin_reg = &info->pin_regs[pin_id]; pin->pin = pin_id; grp->pin_ids[i] = pin_id;