From patchwork Mon Mar 9 18:04:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 448159 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8760C14010F for ; Tue, 10 Mar 2015 05:04:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=Zw21FZ84; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbbCISEP (ORCPT ); Mon, 9 Mar 2015 14:04:15 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:46381 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbbCISEO (ORCPT ); Mon, 9 Mar 2015 14:04:14 -0400 Received: by igbhl2 with SMTP id hl2so23662719igb.5; Mon, 09 Mar 2015 11:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=1+YRU+HUsrcK6hX8DGlz8IN8sXgBp1tcFrYbQ5XAaxc=; b=Zw21FZ84hBJ2EVH32ow/6zisvYc70Kq03iF3QHy/rOscz/vRFoX8uzFRjLJ6St1EXI 11t/ADLHMrzXH3IgY/Y0VaxJUzMSLOPUHFiu0eNCh83uh5kWyJBNJLJqVwwPry3s1uUH 2Eq3gM/TFF4sSjdeingGts7U/7GinEmu0mroFajvSx3XGca2MaeFDBCPNx9Z0Dxu62Tf 3WqBR3ICUugbMZimRg4+AU9+0+tYET0Jrq1r9jVmgbxdPp2J7L4UZh1JKhEX7ba0kCtK K09cfd3fPDDGQM4ER83WLEx+Ff/91Hb4hAutKyCDtcNLm6UDLRk2yBb3ttiqm3+zBuOU YPFg== X-Received: by 10.107.164.140 with SMTP id d12mr2778013ioj.13.1425924253896; Mon, 09 Mar 2015 11:04:13 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:e89d:fc51:1f84:5b7a]) by mx.google.com with ESMTPSA id z9sm91889igw.21.2015.03.09.11.04.12 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Mar 2015 11:04:12 -0700 (PDT) Date: Mon, 9 Mar 2015 11:04:09 -0700 From: Dmitry Torokhov To: Linus Walleij Cc: Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: gpio-tb10x: remove incorrect __exit markup Message-ID: <20150309180409.GA24645@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/gpio/gpio-tb10x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 62ab9f4..46b8961 100644 --- a/drivers/gpio/gpio-tb10x.c +++ b/drivers/gpio/gpio-tb10x.c @@ -283,7 +283,7 @@ fail_ioremap: return ret; } -static int __exit tb10x_gpio_remove(struct platform_device *pdev) +static int tb10x_gpio_remove(struct platform_device *pdev) { struct tb10x_gpio *tb10x_gpio = platform_get_drvdata(pdev);