From patchwork Tue Aug 16 06:49:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: perr X-Patchwork-Id: 659496 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sD2zW3CJ9z9t2M for ; Tue, 16 Aug 2016 16:49:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752985AbcHPGt6 (ORCPT ); Tue, 16 Aug 2016 02:49:58 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:21206 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcHPGt5 (ORCPT ); Tue, 16 Aug 2016 02:49:57 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:message-id:subject:mime-version:content-type:user-agent; b=V8sYw2A8sG9EmYD4ECnnpRlCJXGGokPPEiBX8yOCIvafhpNVT7UgsPVoLM2afyoEe10CckrW19g6 oC43MhX7pJmBoIwmfDro5ZaXT9tZp61bC+qMwstusR471KKTiNrl Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1471330194833544.5012787506863; Mon, 15 Aug 2016 23:49:54 -0700 (PDT) Received: from [123.168.236.228] by mail.zoho.com with HTTP;Mon, 15 Aug 2016 23:49:54 -0700 (PDT) Date: Tue, 16 Aug 2016 14:49:54 +0800 From: perr perr To: "" Cc: "" , "" , "" , "" , "" , "" , "" , "" Message-ID: <156921d1559.dd4cb9f127644.6244938289269001596@zoho.com> Subject: [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler MIME-Version: 1.0 X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: Perr Zhang --- drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf..d32fa2b 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); }