diff mbox series

[07/30] drivers: gpio: msic: use subsys_platform_driver()

Message ID	1560796871-18560-7-git-send-email-info@metux.net
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: "Enrico Weigelt, metux IT consult" <info@metux.net> To: linux-kernel@vger.kernel.org Cc: thloh@altera.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, andriy.shevchenko@linux.intel.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 07/30] drivers: gpio: msic: use subsys_platform_driver() Date: Mon, 17 Jun 2019 20:40:48 +0200 Message-Id: <1560796871-18560-7-git-send-email-info@metux.net> In-Reply-To: <1560796871-18560-1-git-send-email-info@metux.net> References: <1560796871-18560-1-git-send-email-info@metux.net> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	[01/30] include: linux: platform_device: more helpers for declaring platform drivers \| expand [01/30] include: linux: platform_device: more helpers for declaring platform drivers [02/30] drivers: gpio: altera: use subsys_platform_driver() [03/30] drivers: gpio: da9055: use subsys_platform_driver() [04/30] drivers: gpio: htc-egpio: use subsys_platform_driver() [05/30] drivers: gpio: lynxpoint: use subsys_platform_driver() [06/30] drivers: gpio: lantiq: use subsys_platform_driver() [07/30] drivers: gpio: msic: use subsys_platform_driver() [08/30] drivers: gpio: palmas: use subsys_platform_driver() [09/30] drivers: gpio: rc5t583: use subsys_platform_driver() [10/30] drivers: gpio: spear-spics: use subsys_platform_driver() [11/30] drivers: gpio: stmpe: use subsys_platform_driver() [12/30] drivers: gpio: stp-xway: use subsys_platform_driver() [13/30] drivers: gpio: tc3589x: use subsys_platform_driver() [14/30] drivers: gpio: tegra: use subsys_platform_driver() [15/30] drivers: gpio: tps6586x: use subsys_platform_driver() [16/30] drivers: gpio: tps65910: use subsys_platform_driver() [17/30] drivers: gpio: twl4030: use subsys_platform_driver() [18/30] drivers: gpio: wm831x: use subsys_platform_driver() [19/30] drivers: gpio: wm8350: use subsys_platform_driver() [20/30] drivers: gpio: wm8994: use subsys_platform_driver() [21/30] drivers: gpio: xilinx: use subsys_platform_driver() [22/30] drivers: gpio: em: use postcore_platform_driver() [23/30] drivers: gpio: ep93xx: use postcore_platform_driver() [24/30] drivers: gpio: mxs: use postcore_platform_driver() [25/30] drivers: gpio: omap: use postcore_platform_driver() [26/30] drivers: gpio: zynq: use postcore_platform_driver() [27/30] drivers: gpio: iop: use arch_platform_driver() [28/30] drivers: gpio: mpc8xxx: use arch_platform_driver() [29/30] drivers: gpio: max7300: use arch_platform_driver() [30/30] drivers: gpio: max732x: use subsys_i2c_driver()

Commit Message

Enrico Weigelt, metux IT consult June 17, 2019, 6:40 p.m. UTC

From: Enrico Weigelt <info@metux.net>

Reduce driver init boilerplate by using the new
subsys_platform_driver() macro.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/gpio/gpio-msic.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Andy Shevchenko June 18, 2019, 9 a.m. UTC | #1

On Mon, Jun 17, 2019 at 08:40:48PM +0200, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
> 
> Reduce driver init boilerplate by using the new
> subsys_platform_driver() macro.

> --- a/drivers/gpio/gpio-msic.c
> +++ b/drivers/gpio/gpio-msic.c
> @@ -306,9 +306,4 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
>  	},
>  	.probe		= platform_msic_gpio_probe,
>  };
> -
> -static int __init platform_msic_gpio_init(void)
> -{
> -	return platform_driver_register(&platform_msic_gpio_driver);
> -}
> -subsys_initcall(platform_msic_gpio_init);
> +subsys_platform_driver(platform_msic_gpio_driver);

How did you test this? Had you even compiled it?

P.S. Perhaps it makes #include <linux/init.h> redundant.

diff mbox series

Patch

diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index 7e3c96e..5903ce3 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -306,9 +306,4 @@  static int platform_msic_gpio_probe(struct platform_device *pdev)
 	},
 	.probe		= platform_msic_gpio_probe,
 };
-
-static int __init platform_msic_gpio_init(void)
-{
-	return platform_driver_register(&platform_msic_gpio_driver);
-}
-subsys_initcall(platform_msic_gpio_init);
+subsys_platform_driver(platform_msic_gpio_driver);