| Message ID | 1551260094-32570-2-git-send-email-amelie.delaunay@st.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce STMFX I2C Multi-Function eXpander | expand |
On Wed, 27 Feb 2019 10:34:46 +0100, Amelie Delaunay wrote: > This patch adds documentation of device tree bindings for the > STMicroelectronics Multi-Function eXpander (STMFX) MFD core. > > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > --- > Documentation/devicetree/bindings/mfd/stmfx.txt | 28 +++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On 2/28/19 12:55 AM, Rob Herring wrote: > On Wed, 27 Feb 2019 10:34:46 +0100, Amelie Delaunay wrote: >> This patch adds documentation of device tree bindings for the >> STMicroelectronics Multi-Function eXpander (STMFX) MFD core. >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/stmfx.txt | 28 +++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt >> > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > I'm sorry Rob, I forgot to add your Reviewed-by on this patch, which is identical to v3. I reposted the whole series, due to changes in MFD driver with side effect in pinctrl driver, but bindings (MFD and pinctrl) didn't change between the two versions. I stated the changes in cover letter. Should I have removed the bindings patches from the series ?
On Thu, Feb 28, 2019 at 2:54 AM Amelie DELAUNAY <amelie.delaunay@st.com> wrote: > > On 2/28/19 12:55 AM, Rob Herring wrote: > > On Wed, 27 Feb 2019 10:34:46 +0100, Amelie Delaunay wrote: > >> This patch adds documentation of device tree bindings for the > >> STMicroelectronics Multi-Function eXpander (STMFX) MFD core. > >> > >> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > >> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > >> --- > >> Documentation/devicetree/bindings/mfd/stmfx.txt | 28 +++++++++++++++++++++++++ > >> 1 file changed, 28 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt > >> > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > > there's no need to repost patches *only* to add the tags. The upstream > > maintainer will do that for acks received on the version they apply. > > > > If a tag was not added on purpose, please state why and what changed. > > > > I'm sorry Rob, I forgot to add your Reviewed-by on this patch, which is > identical to v3. > > I reposted the whole series, due to changes in MFD driver with side > effect in pinctrl driver, but bindings (MFD and pinctrl) didn't change > between the two versions. I stated the changes in cover letter. > > Should I have removed the bindings patches from the series ? No, as the series should be applied together. You just need to add the Reviewed-by so I can ignore it. Rob
On 2/28/19 3:41 PM, Rob Herring wrote: > On Thu, Feb 28, 2019 at 2:54 AM Amelie DELAUNAY <amelie.delaunay@st.com> wrote: >> >> On 2/28/19 12:55 AM, Rob Herring wrote: >>> On Wed, 27 Feb 2019 10:34:46 +0100, Amelie Delaunay wrote: >>>> This patch adds documentation of device tree bindings for the >>>> STMicroelectronics Multi-Function eXpander (STMFX) MFD core. >>>> >>>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> >>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >>>> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/mfd/stmfx.txt | 28 +++++++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt >>>> >>> >>> Please add Acked-by/Reviewed-by tags when posting new versions. However, >>> there's no need to repost patches *only* to add the tags. The upstream >>> maintainer will do that for acks received on the version they apply. >>> >>> If a tag was not added on purpose, please state why and what changed. >>> >> >> I'm sorry Rob, I forgot to add your Reviewed-by on this patch, which is >> identical to v3. >> >> I reposted the whole series, due to changes in MFD driver with side >> effect in pinctrl driver, but bindings (MFD and pinctrl) didn't change >> between the two versions. I stated the changes in cover letter. >> >> Should I have removed the bindings patches from the series ? > > No, as the series should be applied together. You just need to add the > Reviewed-by so I can ignore it. > > Rob > Noted. I will ensure not to forget any tag next time. Regards, Amelie
diff --git a/Documentation/devicetree/bindings/mfd/stmfx.txt b/Documentation/devicetree/bindings/mfd/stmfx.txt new file mode 100644 index 0000000..f0c2f7f --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/stmfx.txt @@ -0,0 +1,28 @@ +STMicroelectonics Multi-Function eXpander (STMFX) Core bindings + +ST Multi-Function eXpander (STMFX) is a slave controller using I2C for +communication with the main MCU. Its main features are GPIO expansion, main +MCU IDD measurement (IDD is the amount of current that flows through VDD) and +resistive touchscreen controller. + +Required properties: +- compatible: should be "st,stmfx-0300". +- reg: I2C slave address of the device. +- interrupts: interrupt specifier triggered by MFX_IRQ_OUT signal. + Please refer to ../interrupt-controller/interrupt.txt + +Optional properties: +- drive-open-drain: configure MFX_IRQ_OUT as open drain. +- vdd-supply: phandle of the regulator supplying STMFX. + +Example: + + stmfx: stmfx@42 { + compatible = "st,stmfx-0300"; + reg = <0x42>; + interrupts = <8 IRQ_TYPE_EDGE_RISING>; + interrupt-parent = <&gpioi>; + vdd-supply = <&v3v3>; + }; + +Please refer to ../pinctrl/pinctrl-stmfx.txt for STMFX GPIO expander function bindings.