| Message ID | 1502281187-24068-7-git-send-email-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | New |
| Headers | show |
Hi Shimoda-san, Kihara-san, On Wed, Aug 9, 2017 at 2:19 PM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > index 9eb0cef..5c0a94f 100644 > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > @@ -1302,6 +1302,15 @@ enum { > SCIF_CLK_MARK, > }; > > +/* - USB0 ------------------------------------------------------------------- */ > +static const unsigned int usb0_pins[] = { > + /* PWEN, OVC */ > + RCAR_GP_PIN(0, 0), RCAR_GP_PIN(0, 1), > +}; > +static const unsigned int usb0_mux[] = { > + USB0_PWEN_MARK, USB0_OVC_MARK, > +}; What about USB0_IDPU and USB0_IDIN? Are they needed for normal operation, or can they be added later? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert-san, I'm sorry. I missed this email... > From: Geert Uytterhoeven > Sent: Wednesday, August 16, 2017 8:11 PM > > Hi Shimoda-san, Kihara-san, > > On Wed, Aug 9, 2017 at 2:19 PM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > index 9eb0cef..5c0a94f 100644 > > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > @@ -1302,6 +1302,15 @@ enum { > > SCIF_CLK_MARK, > > }; > > > > +/* - USB0 ------------------------------------------------------------------- */ > > +static const unsigned int usb0_pins[] = { > > + /* PWEN, OVC */ > > + RCAR_GP_PIN(0, 0), RCAR_GP_PIN(0, 1), > > +}; > > +static const unsigned int usb0_mux[] = { > > + USB0_PWEN_MARK, USB0_OVC_MARK, > > +}; > > What about USB0_IDPU and USB0_IDIN? > Are they needed for normal operation, or can they be added later? I don't know about these pins. The datasheet doesn't mention usage in USB sections... So, I'm asking HW team now. (I think they can be added later.) Best regards, Yoshihiro Shimoda > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Geert-san, > From: Yoshihiro Shimoda > Sent: Wednesday, August 30, 2017 10:07 PM > > Hi Geert-san, > > I'm sorry. I missed this email... > > > From: Geert Uytterhoeven > > Sent: Wednesday, August 16, 2017 8:11 PM > > > > Hi Shimoda-san, Kihara-san, > > > > On Wed, Aug 9, 2017 at 2:19 PM, Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > --- > > > drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > > index 9eb0cef..5c0a94f 100644 > > > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > > > @@ -1302,6 +1302,15 @@ enum { > > > SCIF_CLK_MARK, > > > }; > > > > > > +/* - USB0 ------------------------------------------------------------------- */ > > > +static const unsigned int usb0_pins[] = { > > > + /* PWEN, OVC */ > > > + RCAR_GP_PIN(0, 0), RCAR_GP_PIN(0, 1), > > > +}; > > > +static const unsigned int usb0_mux[] = { > > > + USB0_PWEN_MARK, USB0_OVC_MARK, > > > +}; > > > > What about USB0_IDPU and USB0_IDIN? > > Are they needed for normal operation, or can they be added later? > > I don't know about these pins. The datasheet doesn't mention usage in USB sections... > So, I'm asking HW team now. (I think they can be added later.) HW team said it is an error in writing, and these pins descriptions will be removed in the future. So, I will rebase this patch on etherevb pfc patch which I sent. Best regards, Yoshihiro Shimoda > Best regards, > Yoshihiro Shimoda > > > Thanks! > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c index 9eb0cef..5c0a94f 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c @@ -1302,6 +1302,15 @@ enum { SCIF_CLK_MARK, }; +/* - USB0 ------------------------------------------------------------------- */ +static const unsigned int usb0_pins[] = { + /* PWEN, OVC */ + RCAR_GP_PIN(0, 0), RCAR_GP_PIN(0, 1), +}; +static const unsigned int usb0_mux[] = { + USB0_PWEN_MARK, USB0_OVC_MARK, +}; + static const struct sh_pfc_pin_group pinmux_groups[] = { SH_PFC_PIN_GROUP(avb0_td), SH_PFC_PIN_GROUP(avb0_rd), @@ -1352,6 +1361,7 @@ enum { SH_PFC_PIN_GROUP(scif5_data_b), SH_PFC_PIN_GROUP(scif5_clk_b), SH_PFC_PIN_GROUP(scif_clk), + SH_PFC_PIN_GROUP(usb0), }; static const char * const avb0_groups[] = { @@ -1438,6 +1448,10 @@ enum { "scif_clk", }; +static const char * const usb0_groups[] = { + "usb0", +}; + static const struct sh_pfc_function pinmux_functions[] = { SH_PFC_FUNCTION(avb0), SH_PFC_FUNCTION(i2c0), @@ -1451,6 +1465,7 @@ enum { SH_PFC_FUNCTION(scif4), SH_PFC_FUNCTION(scif5), SH_PFC_FUNCTION(scif_clk), + SH_PFC_FUNCTION(usb0), }; static const struct pinmux_cfg_reg pinmux_config_regs[] = {