Message ID | 1494527071-6412-1-git-send-email-agust@denx.de |
---|---|
State | New |
Headers | show |
On Thu, May 11, 2017 at 9:24 PM, Anatolij Gustschin <agust@denx.de> wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. > Thanks! FWIW: Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> It will fix this kbuild bot complain: https://lkml.org/lkml/2017/4/2/209 > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > Changes in v4: > - move stubs to gpio/machine.h > > Changes in v3: > - add stubs for !GPIOLIB case. Drop prototypes, these are > already in gpio/machine.h > > Changes in v2: > - move gpiod_lookup_table out of #ifdef > > include/linux/gpio/machine.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > index c0d712d..f738d50 100644 > --- a/include/linux/gpio/machine.h > +++ b/include/linux/gpio/machine.h > @@ -56,7 +56,14 @@ struct gpiod_lookup_table { > .flags = _flags, \ > } > > +#ifdef CONFIG_GPIOLIB > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > +#else > +static inline > +void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} > +static inline > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {} > +#endif > > #endif /* __LINUX_GPIO_MACHINE_H */ > -- > 2.7.4 >
On Thu, May 11, 2017 at 8:24 PM, Anatolij Gustschin <agust@denx.de> wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> Patch applied for fixes with Andy's Review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 12 May 2017 11:27:42 +0200
Linus Walleij linus.walleij@linaro.org wrote:
...
>Patch applied for fixes with Andy's Review tag.
Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ?
Any issues with it? Or can it be queued for v4.13?
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 12, 2017 at 11:38 AM, Anatolij Gustschin <agust@denx.de> wrote: > On Fri, 12 May 2017 11:27:42 +0200 > Linus Walleij linus.walleij@linaro.org wrote: > ... >>Patch applied for fixes with Andy's Review tag. > > Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ? > Any issues with it? Or can it be queued for v4.13? It was probably not sent to me (just to the mailing list?) or some other hickup. I will try to find it min my mailbox. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h index c0d712d..f738d50 100644 --- a/include/linux/gpio/machine.h +++ b/include/linux/gpio/machine.h @@ -56,7 +56,14 @@ struct gpiod_lookup_table { .flags = _flags, \ } +#ifdef CONFIG_GPIOLIB void gpiod_add_lookup_table(struct gpiod_lookup_table *table); void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); +#else +static inline +void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} +static inline +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {} +#endif #endif /* __LINUX_GPIO_MACHINE_H */
Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() for the !GPIOLIB case to prevent build errors. Signed-off-by: Anatolij Gustschin <agust@denx.de> --- Changes in v4: - move stubs to gpio/machine.h Changes in v3: - add stubs for !GPIOLIB case. Drop prototypes, these are already in gpio/machine.h Changes in v2: - move gpiod_lookup_table out of #ifdef include/linux/gpio/machine.h | 7 +++++++ 1 file changed, 7 insertions(+)