From patchwork Thu Nov 24 20:45:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 699011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tPsW76nR9z9t0H for ; Fri, 25 Nov 2016 08:18:11 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axentiatech.onmicrosoft.com header.i=@axentiatech.onmicrosoft.com header.b="qlEkc0GJ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966361AbcKXVSK (ORCPT ); Thu, 24 Nov 2016 16:18:10 -0500 Received: from mail-db5eur01on0094.outbound.protection.outlook.com ([104.47.2.94]:64339 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966342AbcKXVSK (ORCPT ); Thu, 24 Nov 2016 16:18:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentiatech.onmicrosoft.com; s=selector1-axentia-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hyTsU3eqlJZgbogL5mH8KKnAzfcbocpq/wM7yXAi1FY=; b=qlEkc0GJXaH7oW3P7glXm1z+HC9EbASLidMKmd1SjLe9SiB3DRgvXugLgiw7Yb/vw2xF22Fra1JQZe4HRrMgTC7kmONGZ0OY4F5h3M8NMdE8dmb9EUR7+iS3I8M9mgIXYqcJAFvejqYRWcIoB43y6sGqEBiRXrVEZZn42LgAWOM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Received: from localhost.localdomain (217.210.101.82) by AM5PR0201MB2305.eurprd02.prod.outlook.com (10.169.242.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8; Thu, 24 Nov 2016 20:46:06 +0000 From: Peter Rosin To: CC: Peter Rosin , Linus Walleij , Rob Herring , Mark Rutland , "Andrey Smirnov" , Neil Armstrong , , Subject: [PATCH 1/3] pinctrl: sx150x: use correct registers for reg_sense (sx1502 and sx1508) Date: Thu, 24 Nov 2016 21:45:18 +0100 Message-ID: <1480020320-28354-2-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1480020320-28354-1-git-send-email-peda@axentia.se> References: <1480020320-28354-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: DB5PR03CA0052.eurprd03.prod.outlook.com (10.164.34.20) To AM5PR0201MB2305.eurprd02.prod.outlook.com (10.169.242.149) X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 2:j//rY8OCpYb00z99Ze+3FthH44a8hUN0x0bX9XO2zPDIePF7ucCyyo/AxR6PRo7YLEcGKUXT1qKbigtnCnT/4VPf+3KQn7QyEMYkTt2s97eUO4+TzUPz23gQXQTaQxba06EVG7UHBREjXu0ZzcQ14nfcv8hTy77CkyKXn31Jdss=; 3:jUAGOcNGCMUYuKQi2W6vHImtluyKf2RlDlwdEOxNml0gX4AWIMpC/U5uP+lKSnIijJHoAOXT/z9Ip2QERrcBGcdn6/ExZmJ97mn/SRC63ddCve2D6CaXKs2lV4JzUg5MG1fh/V9EHp0aZhGkaXJ9ocPhnUnqpjHd5rYxak2K/2s= X-MS-Office365-Filtering-Correlation-Id: e9afdd4d-3337-416c-26d4-08d414aaead1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AM5PR0201MB2305; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 25:gwHc59vhSyKoQxNAdwWrHccmuy4427yMpam3Qmf8KTv7vYndubx3m5LfHKnkTPrxovTjEY6nHPqKRWq1s3xdBvt6yFtwicoDNAumic8b5dhQT8dnnD7i0vSbFA1j3G99DlrBkb9yqo9c5c7TEzw9clcLJOtb4irWcPGAW3BuajeqnT4GBIyowOyO4Q/IPr/AK/y8A/Q9liQPKHriGMxN3InCiVyor6ec2J+OOj+10AgaGsOBASrPIVZ9OvdUi0F3Bq8KiAPhmDXZoezxJi/s8rXqWjA6LoqfAX0KOW7h8G68GPj/BgByFamjBe3DYYFXxITnegHPWl+IoWbb4F5bxtkNO2YpEw6fjSoieQnOwX5ApqgBLojBQmM7FpB5aVpwyV65Nf1MuPPdohajR9PsVznAqedF5GmUBYP30eTw/y3XCGBwGHuN/jo+EuFfTy4olniE2/uMIQ2H6wyK98G8Qbqh0mksBng5cq97PRtOL9T22BGUhfbzSaD0RHhd8QwUOAztuDM111w16mkftJqbNU/YZmumEjc+gPqXzw7dPYrvEoTB9OrCJ9CjBTT/p6dT2/rLBTaj8KqGXITEO/JorSBpoJunrlboxcxX1y5sBBW753nEoRKGhHlbph3SjyR28/XhkhYFFyKDXTm/36a9UX4Ef0tTs2nvd3kySh/TuYCpKkB0TLi4M2w3hh2/ZtRiplLcjjidy1WW4eHwMEgi6Likhx3cIveD+rQgi+zJ9ljeA+kz3y+zwJm6HzGuiIoZrvlE70AZyOcHB68Yy9BmeYretYT7F1Yg+AgMhCjMQog= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 31:pIUG4tQEh57Fu6n8j9fnE/BHnbZk2kIC0pJzLvtgXgeqamAao7+SAJOM+IgptVgoz65WEBLJMT8Br8Q/fvBGINTacMUGfPTgCe/ssAu2yiozN7V8jy+JhS4FH1DFAnUQAtz264JY5ZPUf8fiKIIur+Uye26bpiKXJ5ytUcUvwRr+6kEKd5Ho4DiPrKik8CiOKDh8foeRlqrRRye5cVN38kDn7S4mog3IgtNpik+UU22v5edX7rejrRHBt60Yzb1XcLnJYNGM+WgYEMqRCJ8uvg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6045199)(6060326)(6040361)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6061324)(6041248)(20161123562025)(20161123564025)(20161123555025)(2016111802025)(20161123558021)(20161123560025)(6043046); SRVR:AM5PR0201MB2305; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0201MB2305; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 4:Oc7eVXww2MqcVV8Ielc7fCzSNUpr/mjmpeHsb5Uh3RTrvA8dS+Zz/7dZPfp1zSH52yoag1Ws4nmmJLZnHjIWHjOAvl2RoamY2gBvJYN1rBBu9LppsWmzwR+RpYL3Pg7aFDPn4FPKooFn7PRO3NFwaePyKHN6zj86Cz0pOdxDic/7uP6/NamST/NbDbkZqpEa6YH56BJ0RC1rkXrYHSzOHIPD580ZUM5xG6jCwUIIRJEVXbrWuw1ur/Hny59X6FLmq7V57S6hLvwidGr5i4wHHEVYSCmTwytt0yhOA/B1XwJ+NXcBu7iJf9mvTosFvleNCoBnHRL4Ej8XnchP0QcHGa+lXYzEVszksPc2l4R1UdwNUfkMqnkBzGJFB/akDyRPobuwhyFWImoktf9SeowvchljVudjhxRxLCDqAKTlDAXSosSQmqzJN1MMQh1bdxx6/eIP/E8wSWB/eF56QLYY//OGsckjwrdMQPrr3cBMUpyED0Ky9yRtgy84+g3V0ciCVIJhlXdHWfZlXwviX2a07KDWgtAyEIoj4LVl0frgm0ArTAsPnnBy7dRwXuYiFugw44eRNsqRfFqHQbjJQ6ci8dIUM87aZ8bbFUEFBICODmnYWo/pnjkkLUX6HWHYTdwmqfASV+2ELzhZqUg9x+Y6kI6WK+W87yS/2olRhCs9/rZbmAzrSQc5JQt3tZEvWCBqNVu1lWZ2trj4MQ0xbw1ZloEJNHyH8WxtDArNjkdARlE= X-Forefront-PRVS: 0136C1DDA4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(189002)(199003)(92566002)(5660300001)(110136003)(305945005)(2351001)(2950100002)(38730400001)(77096005)(6666003)(74482002)(4326007)(39400400001)(47776003)(39450400002)(7736002)(48376002)(189998001)(76176999)(50986999)(2906002)(7846002)(50466002)(5003940100001)(86362001)(42186005)(68736007)(39410400001)(101416001)(39380400001)(97736004)(575784001)(3846002)(36756003)(81166006)(8676002)(106356001)(50226002)(6916009)(81156014)(6116002)(39060400001)(33646002)(105586002)(66066001)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0201MB2305; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0201MB2305; 23:AMCgAPfHCmG2Vkk1L4gg4SihG0xkMOtxRrtGYxT?= =?us-ascii?Q?ACqfL9t8iTK3zxHEpMfo2TuIoiDdRIpgZGS3b/10/nVYQNYo/bjYtoy3g9er?= =?us-ascii?Q?t7SsgMiqhod1AvY78TTTwwB6dWXl04sCJG0JkUq889NgR5etutbZMd3mbgwE?= =?us-ascii?Q?2R/sXhTV9uIi0hb2rwYGFqL//jTJkMWizboWHyFdu1s3jH59GVTsyRYFltq6?= =?us-ascii?Q?ZqoWoY7V/AOe6anCK0Nkek/OTQDYtklfaJssVrBJFdbGnBcAVg2n1eSUiSmD?= =?us-ascii?Q?+pkqDmdSjHbe836Zk/tAQ3YfKtdX6FF89qcIgSn73aHj+LnXmeYfRQSV3f9H?= =?us-ascii?Q?FjCEOAQafCJQeCqeOaZcN4JftB4yIKtu/2GvSG1NrtgKFZT286GELroILlVm?= =?us-ascii?Q?X7uzrLNpeCwYNUUTPmiRIR09WoFixP/aWEqSS3Sh8bJn2D5+yrHu6VLxkzzK?= =?us-ascii?Q?iZPHml6roarRlsXnNHhFLOZ+9cyRCJvruG7or/kEM9O58rhlgm0t5rzzzw5/?= =?us-ascii?Q?Ik7c9EHmA+E0En8Hdge/H17tCvqfl7EFCd8gyIYgcI52WxgaHTHEcR9IKfdU?= =?us-ascii?Q?mH8ky1pEU9cxh57DC6UIF9+u5T7GG8sgQqstNc2tNeXGt9szVvqyDa5/OgNQ?= =?us-ascii?Q?1FFR4ACijspDp+wiv/4uOUT2EPu1riB7gQddd7Fw0y8iRge0jGqnBPV+dyPz?= =?us-ascii?Q?9SGMuPne6OjPt0xhMv/lfVlDEOhn+4wnMnu1sGfRpG0PJuxQzuzLVoiHIyfW?= =?us-ascii?Q?Onc0ZUU5ZQSKofYT8dCOTZLLJqPhMERDl+PARdyNXMeLAQNVj60uwGmgIyNo?= =?us-ascii?Q?+GK+Xp7P0ZwDmGdnr06CZgQH5KoSG/nnEnQa2VMa/vkrsVfL5euYrVCc4BcZ?= =?us-ascii?Q?Ju0lHzdgoaxXD5nU++jQybLkTD2Pvx0aQ3xeoVOLVxdpVeqQ//XkIi9tjbbD?= =?us-ascii?Q?SYCmDz8JmeYOwodReztqHxtqmJOgHHepXM0A6S+9R40sT3P9KT8/9fdznldP?= =?us-ascii?Q?fOFlFnEIOkpsTxFcNbPm65CRrswICtTyFQhKhSTP3AsBBuQVMMwFqvIew5+q?= =?us-ascii?Q?x6qLEc0kgJmUYF/mQGNf4JcHtNtxBcvPDScCJZ6Uftgwyv2Os4yWCsekRMxb?= =?us-ascii?Q?59tTumqb0a5Ak+QO4tYzmNeTaAjk+2sB/oKPBNxPxx3EOa6Dt/o51lYvoY1M?= =?us-ascii?Q?FuP2RKheqz8Wi/2T0Lu9SvBjvh7X6YCJB6JKpGVOzrflAtvt+IdFr9cG6hJG?= =?us-ascii?Q?AAX5YJ0wdacGRb10XBgM=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 6:CS+7nGijLL1+WDTekdl8/0CmfHR/zfZ/HIYNuxOVI70LG/ObPpWGuK5momdVudQ8N/8hosYcTmSZvh4pe5kJ8uL5KF6EHhkHhqt/FWJ5drEakabHPGTavAzhWkvQ8d78YIT/o4sqRTcMW9VFX7K2lKpgg2HDc4Ic5ybOlRMKtDuXyvgXetZnnqzQ+bZn3+fN+6WtL9QqF3Nz53QRSVFqOMsW5GSRQJp39F1o50kt5GssuGp55Itz5EPJWQATjyJzmDjybHS+noKnIjz7FZ2LlY2YQ1/VJz4tzjvNypx6MFUOqv6n0vrZ1GAqRw2iQf+9UnEhVBY8eCNq3OIj6CbhcdUZhb3/iMQN7al4o/3ON8Vks42v/G+hMigNPpB0YCmy; 5:ZSCHF/WlANqGb/WpmaWgaF4izP1Q3WNAamN3tY++o93i3Eb95M5cB/I85wyaX8rUxMEz+YKFgrb1vWweYN+WRDCDCEM23x/EdekbC2gm/HjAyHDNKFh+Ksl99s4gOQW46z+rSj1HQBOi7yUq0O5Nkw==; 24:0Hd+oBdpiPR9HC43v7CrPQO5v0uk5s3/ZVkz0AFdAUKdtIwedkuPlY6XVuSAvraCpI5EkOQkMXNfa207ZhqLNs31TBN8FmqWIyTQL6dPCYI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0201MB2305; 7:U91v+HEj+IlEAGaXMcLq21LbypIAZ1nsLwXJte1q/TU/JZjMO+taJcDSB1BnYaFpL3XneMBCprz3dmtymTGDXPhuzk9pSikyiFZNc+vwoaysD2CzaFaE/hG+8ymycg4AoIqu380nioX1NwwHCltoxrOedVtQwzVmLiuBD6SmXrXtPkAClZnF9ntdrFoDruruIeuuEF7Y2U9cx5KmdlzTg8/csBRbGynbwghwVwjV2quxXbRIB6BjPU3NCBLp5RRlszR5JIUX7Ue01goXtuzaQMAgxLs2qZOTYxxchZoJRhPUFpv4No3iqkCENRX2bxOfHw+p6898ji1gptASy/TTXvMdmqeB4yIMPtUowmQuJQg= X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2016 20:46:06.9582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0201MB2305 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All other registers on these chips are 8-bit, but reg_sense is 16-bits and therefore needs to be moved down one notch. This was apparently overlooked in the conversion to regmap, which only updated the register locations for the 16-bit chips. Fixes: 6489677f86c3 ("pinctrl-sx150x: Replace sx150x_*_cfg by means of regmap API") Signed-off-by: Peter Rosin --- drivers/pinctrl/pinctrl-sx150x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index f9e559e22537..a19c814843aa 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -156,7 +156,7 @@ static const struct sx150x_device_data sx1508q_device_data = { .reg_data = 0x08, .reg_irq_mask = 0x09, .reg_irq_src = 0x0c, - .reg_sense = 0x0b, + .reg_sense = 0x0a, .pri.x789 = { .reg_drain = 0x05, .reg_polarity = 0x06, @@ -221,7 +221,7 @@ static const struct sx150x_device_data sx1502q_device_data = { .reg_data = 0x00, .reg_irq_mask = 0x05, .reg_irq_src = 0x08, - .reg_sense = 0x07, + .reg_sense = 0x06, .pri.x123 = { .reg_pld_mode = 0x10, .reg_pld_table0 = 0x11,