From patchwork Fri Oct 21 07:31:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Gang X-Patchwork-Id: 685014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t0hRp41W8z9t1P for ; Fri, 21 Oct 2016 21:16:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754869AbcJUKQx (ORCPT ); Fri, 21 Oct 2016 06:16:53 -0400 Received: from mail-by2nam03on0044.outbound.protection.outlook.com ([104.47.42.44]:13216 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754865AbcJUKQv (ORCPT ); Fri, 21 Oct 2016 06:16:51 -0400 X-Greylist: delayed 3589 seconds by postgrey-1.27 at vger.kernel.org; Fri, 21 Oct 2016 06:16:51 EDT Received: from DM5PR03CA0023.namprd03.prod.outlook.com (10.175.104.33) by BY2PR0301MB1621.namprd03.prod.outlook.com (10.163.28.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.16; Fri, 21 Oct 2016 07:44:02 +0000 Received: from BL2FFO11FD028.protection.gbl (2a01:111:f400:7c09::139) by DM5PR03CA0023.outlook.office365.com (2603:10b6:3:118::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5 via Frontend Transport; Fri, 21 Oct 2016 07:44:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD028.mail.protection.outlook.com (10.173.161.107) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.669.7 via Frontend Transport; Fri, 21 Oct 2016 07:44:01 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9L7hvtS009747; Fri, 21 Oct 2016 00:43:58 -0700 From: Liu Gang To: , , , CC: , , Liu Gang Subject: [PATCH] gpio: mpc8xxx: Correct irq handler function Date: Fri, 21 Oct 2016 15:31:28 +0800 Message-ID: <1477035088-20587-1-git-send-email-Gang.Liu@nxp.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131215094418314915; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(77096005)(47776003)(87936001)(5003940100001)(85426001)(6666003)(5001770100001)(5660300001)(626004)(8936002)(229853001)(105606002)(106466001)(586003)(50226002)(92566002)(50466002)(19580395003)(86362001)(68736007)(2201001)(104016004)(50986999)(19580405001)(11100500001)(8666005)(36756003)(4326007)(2906002)(305945005)(97736004)(189998001)(81166006)(8676002)(48376002)(7846002)(356003)(81156014)(7059030)(32563001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB1621; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD028; 1:trz3V4BttN1aP//wA3AGczgSkj+3vK5GwpDfh2ebLZM/L98K1/5buwmUxiGIv0GVinhHg6OBOzOAaN2MdUcNUgSdvn9PZZUqcz0tF/Wgd33hH3OAyKobeFP/LGoX1SIem9iQYDK218hro9mdiXyL15hyNe2nqGI8iVac8La2M8qpPxgTPV2NOG2STDAUCqasCpKxg8l8HajvE/bofraP2EeCDdjh5qKlhxULs6j0bFqPGaU2m8rC9wK1owbbpZS5RjM1XtAc3OiaLR2Im1y05Ctv5qj3gPUsEaBxCTK39tPvRp5fEPjWuITzi17+ON1e6nNo73qoeTU1wsrhAOtw9a1+Llb2YflzsASMBi3Ix7bAmZVTG/+YzvFg8IrzUxg+mYGY8zpEgLF1jBBvmoZ5CrIPcDDVPvzwlrQnLT5OKuTOFnhGFiaiS69Uy7EWf59z0hsjfVUAsHAROgbESOBNqBKVzopgsMzu4+TmBswqBZtGtLTklcG1NRiZoN2SfNUYGbpcfWDQcwoYoBBrHa+vLmZdRsfX4y6SAzCXwA2SvUj8YmblFQZYig9+D/BWrpo4JvTcz00NExqb0XF60HuwI5zzmpdmx/UaLo28PT+h3vI0DylZOgrvztty6G5z3ytZCpl52SLYwQmZjFZURTDMj8/7qjnV+xxTjjptopWFwltp18veAiyGKm0lygA+BnkmBozCQaWiPeSnXWXXvt/vFlzdEqp14nApkqxFC9gNXfM= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6c751c56-4084-42bf-16a3-08d3f9860670 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1621; 2:xMmWywvC0Zmk8Fnp2lD+GWYviyNJU11HjODfFI9+NCptZRkeQU99GwoDJsx7n6/vYISs7u/eKKRGawNsdCMEbeKIx7HBoJGiqXqewA0+1Rm4KPMXnqz+G1+pLiWLw2Z983AV4rLwI7/2u7OJgjZ1H6KCPIi4cBxQfVKaMOW2UB1pXsGYT3di5CjC9BbsDxWeGOU465scqInXKuDPedn4uQ==; 3:gG0QQiQHiwPYTq09XHTCKsDtJWWSwipk3pbQNxiiZxBOmAXa+cR9jMcCGHmooHfXu6ZnUlI4UmwSG8hZ8zSZw75ykmWtpmYzHeHp7CDRLNdcvea29cLk3aMOT8Y3EgUm1yELS823hgJdjPM3a+xHS9h5FHWD+7hGy4dqvSDHyotNIlOVnb5pGHsEd6ckWiy8MGzBB9L8gN7JAXGgWXzbOQ1YCK+0djvwL8Sl4BxbaYjo8thHy0TaDQfLjSN2Y7B+; 25:1908lV7Dh6X75mvZc2IL/+l4YVw/uj76ZDUdhrTIkKPMCClz/cEakSPhJRHkUANEsPOpVW8wWszPG1tAU7d8IXc5zU63OioH981C8bTwOpKKMsGHBwjFxudh5ZNjCRtVXA4tsahzMxlZnGle8ggeZWhedhHHJ/4buzVVYVmLiNwMH5kPrUnYk/AF5Kdmgm6GGp1KRLs63vkwegaAxN+CBnBLfLyzAxstHqY3OHpS963Akpi0e5tuOLgUxQtLAdhvJzMFAzdsPNaT6AK+5yLATr860XK1qYOqD4L6CeS6dvI/c98T6OniBoZ08pkDDOiMv0jvQ6zpPa/UxFGdLH2KztSDHtY30UsKB9ohwP0nOifFI/NgxPuBxPHoWQ74ayu8Z+A/4LXbge97o65iGQHhCzYCYH7hhCHQe3zORtj031ne+owEbzfiY8Q/J6FTGGaV907GcvKX1KnFECzw/+p1NQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1621; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1621; 31:R6RnkkpbIcGvfwLQ7k8LDa+o8xgwJyFJdAWwLZVtrIJb0LrRlFb3OyuYrxae2RoD/BlhkncLVgfQoav0+hSYKRFwPKFV5pwHWQ/BXl0gm9Zlub7C0Q5WJsSX5izbIrRiI3gLafCC9cdQXXw6ESP6KhXln+WF18ZwWxGZKdHFqDt6wt6cp/eS8q4fTFIOLCxpSOo18NNfx5KJLqmu/2nnEjJXxILKcZ0jCXpvpKjaeO1K50ku7SAfxOnbn8B/u/X46Y/jY54XR3CX52quRfdpfc/iSgHa94Zf4qgQlpGWaVA=; 4:FKAHGgsOIyvfzqDFCcf1H+fzTmayZxDDEwnuBj0OixQu72Fh2EQEv9Gv9FkH8r1CXIYXNhXPCChgQvj7+qGII4fPBZ6vAD/fZ4yHe2C/5bNX0DdPIqRhqM/Ukw/LRnYT6XR7MAIykzZdrnWcBdoWjb5rt7LVy9Do/DNhrMDqG8q6JN+NqXe+BfUHRj8eHTQxTxMCsoPhgNsjpuqMEa44uSqpgQfelW8N4+DLBVB81ZjdVsNWti4X/sDNiczsbCZRomhoYYIGN8JXMeLSMHH8PWH6HgRSjPoGx3jfKeLSGP4j+qDNo/HQFxchxVT8KiFyT3lrvI8LBt5YVqwz5SyCoL5geOkUCc9dLYRnKuISbLz+2lxdffKvXMdooXoiJtsj8IO6yanounh70+DsOBtOISu3YdPQxSpRMLVolxIGQiOotOpa5CKMyCLUmZWJI03362BgTZua0FcOmtS+2nE9cJmcSTpV7sTBPBNgowWnlbUlusS+10HF7gpUCbI9Or+V2a45f/jhtWb2AsSUEkg70KYEIe/soE90DPelNUELkbLDvxYCk3NhxfLkBYcqCr2N X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(13023025)(13018025)(13017025)(13024025)(13015025)(3002001)(10201501046)(6055026); SRVR:BY2PR0301MB1621; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB1621; X-Forefront-PRVS: 01026E1310 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB1621; 23:NSfvOCXjbMpb+qYR8VbE1NCHHUbMpXAcC+HFEnU?= =?us-ascii?Q?Vc5fue1HaJx/cutg5UDTYp2W+PSVdDBWbvkWIDpYmeUKKYfL7iEyjPiCwGdL?= =?us-ascii?Q?2vvOGYs8YNRkQyU1wRJTjjHPHWXL6z9C4MmYVeakGGWPDfPkHP0XDYsZ/pbv?= =?us-ascii?Q?8ciEcHoF7p8kkxtM6feAIL+02oMOV/NGtv8J5IxdlC3h49oWZ+gvPOosm6hk?= =?us-ascii?Q?rgI5MZpzjJjz5xDNhRTOlw4z7Q8n25mZfegYX2CAmtkYsd5h/mPmAZU5IbAx?= =?us-ascii?Q?YJLUEjs+D0fg2wX64/J3CeT6oZirVu2QgBpzKejofEEVuEraCbyYrDV/w8l8?= =?us-ascii?Q?pxMt5L/jc1eRflBKHxaTATwQbwYeSSBDfqOL19PP6mp5hv/hoflTM1WrFHIK?= =?us-ascii?Q?hf4yWeT4CF32Y6XJNh7jn6Q10Hdf13rgxB8OtAlxWINWLRXsd+4vgD7hSWWw?= =?us-ascii?Q?xINFjhoHFDRbgtcFdXNMvJeSvmKZF0OV6ksrnfDmI/ZDXmXwJ+Mb++QWq6of?= =?us-ascii?Q?GkxcbuMs1IS2Be3kAuWTOvln55kOCcfDQ11TrIPaDcIcufJyv0iX86Hdf+Ds?= =?us-ascii?Q?bTFCdDNjusS/U6idGFcI2cCXIKlpR6IK++kbFlc/loKDg+L8YUYtg3jItqIz?= =?us-ascii?Q?oWFf6D+x7fQOeuOcA5VSEO9alzBW4m3Zma4oVzI219TLFwBQB4Jhtrg9j+dc?= =?us-ascii?Q?xFZBtGwPrhoovC4lalUVsapztXi4wMz88VWVVz30CHbjSXMIPh4uSDNCAeXE?= =?us-ascii?Q?cIzTAez6LhjBtIHxLbgmBPk3uYO6hv+KUVb9/zL699iws+q8AFKbbQxLnXRO?= =?us-ascii?Q?RqeirOxBVZj+6/fwQ3cojncVooldf2lEt8qTt64kq0ss9LcpN6/BIT+cioQ/?= =?us-ascii?Q?2WLhCRJKYpO5nQocJtukvROglqcax6tK3o0cLSMEIN9/eVj2mgQdwpa3qyRy?= =?us-ascii?Q?Z/jx9ixmS1zgsrLumO+vyVflaTLctSLiGM9TNU6LZ8UbPj7mfs/aWqma6KbK?= =?us-ascii?Q?1eJB3gngEntKuWNy0SEK/D6U0i5iBPHWQk/qMCEsSqELzqO53fNe2usUYTPA?= =?us-ascii?Q?aW+YGdF6+UVaek9UrxQCAPS0iTCeoW9mhhmgp3DYldKJoCdOtutibTwJFUOz?= =?us-ascii?Q?f3MnFA/d/6TJsRy/IOyHswb3MCvtq7NMEFZXCSqqLwBaBIEtoulQoTcBVn4c?= =?us-ascii?Q?gJAb+7oJ0E0xnTlE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1621; 6:nYTBIdkfHqRP7rvYR0pNA21IO4J8SFJ6sBW4jhm/MWlflSwv4DNfRZTAMiVVFnO/yNDNvpzTvPU/Tje/q9ifXPbCjU2FkHKAAu0ofezXiF0b2ujNHAD4QufWp7uaGkXwlVXMik/bmIaonLlBj/4FvxfncR8pZHOPXmvg3XLBVwZtmhdD4SzTW4S4n4NkO6bQFm5Kss5qnK/MboZ1KKXyfiju89HrPLyCZvN9LCkgbqtPhkbi61uFhZeaDQywBn8Sgh8MkgIXu6tB7vLi9fokxVPnBVopbFsWE58HhKVS/mY82gM0kDIgucTPhvsrJTmm; 5:4y3kPKZi7tWNeCfw9UVXzL71Ey8YjpUP/3F+RE0MLfPzhlop3ESDFucRMPwiWQQOTxCbagjsuao+YBcpmfgf51ZkohoziiyHPXN0fZMCW0GP7KDMdu2ilu5lKD246hW1RYJPU0CVvG9EMQCzk16KdZhpmj+TlseBdmPA77pGziXWps3SNsiTokUyIcgRsbRN; 24:PtMQqAIc6xjwOZZEMPSMz3TIZMfZ+mg/wSApVoc1Ddy4zrYMo9LGjpRahU/z+XmeksAMOfycD8Dcepqhz7Jlk7qj965p0SlI2UgSrtA/vjc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1621; 7:f4p4HZj1aqdA3UAXTr93qD5Wax51+1Ig1XECJkVfKhV7ZUIMakvno4nJ5cT9FKOlvepKCWLLWtJ8xqgHrtQc+tvfrgMKQ/FUJqtu7pVjdWkQV74fheHCmslqVMqDC+OnkVk6lSTKZVc7xj6Z0/hOqQxl/eKDUrGMSP7W7lCn+3TQK3m1KMBpx3QsorOy6U+BNPJR0vOiuBxxf3c5cuIO8wnXcRkAbT/VZzi+QCmQKipy/QlwNmwHpIUw/smDAH9gTk8Z6fhepxrDy6MybhCvKIBhmr9LgkMe0uXwt4/PlHztD7HyfTTzfT8b5vwHZMQ9nokn3rRLALhNY+bfZrfE+20eGEQeAccp1jDyIAhzBnI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2016 07:44:01.6598 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1621 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From the beginning of the gpio-mpc8xxx.c, the "handle_level_irq" has being used to handle GPIO interrupts in the PowerPC/Layerscape platforms. But actually, almost all PowerPC/Layerscape platforms assert an interrupt request upon either a high-to-low change or any change on the state of the signal. So the "handle_level_irq" is not reasonable for PowerPC/Layerscape GPIO interrupt, it should be "handle_edge_irq". Otherwise the system may lost some interrupts from the PIN's state changes. Signed-off-by: Liu Gang --- drivers/gpio/gpio-mpc8xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index 425501c..793518a 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -239,7 +239,7 @@ static int mpc8xxx_gpio_irq_map(struct irq_domain *h, unsigned int irq, irq_hw_number_t hwirq) { irq_set_chip_data(irq, h->host_data); - irq_set_chip_and_handler(irq, &mpc8xxx_irq_chip, handle_level_irq); + irq_set_chip_and_handler(irq, &mpc8xxx_irq_chip, handle_edge_irq); return 0; }