From patchwork Wed Jul 6 12:02:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 645238 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rkzvG1CnFz9sDb for ; Wed, 6 Jul 2016 22:04:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=lyvEoWle; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbcGFMEZ (ORCPT ); Wed, 6 Jul 2016 08:04:25 -0400 Received: from m12-15.163.com ([220.181.12.15]:49789 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbcGFMEZ (ORCPT ); Wed, 6 Jul 2016 08:04:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=v1y9c yE4RjJkuzuP4pKUnOP0ej16KtHB002hl9JG8yQ=; b=lyvEoWlePnpwhzmN6HjKp xshT/qN7YGzpMrqJdpkiwqu3TAePSsgb2vTW9qJSY6XdqixCc5JERXS0Z6aSQf/1 +ToEU7CpG8gyhqX0Sm0aHxcvnwKMgo+eizUGCUw1+inKG44JM4elVfRwqoLGuYYe rGPUF6dCtM+4KKycsothBQ= Received: from localhost.localdomain.localdomain (unknown [49.77.207.185]) by smtp11 (Coremail) with SMTP id D8CowADXNtNr83xXTWIrCg--.2904S2; Wed, 06 Jul 2016 20:02:52 +0800 (CST) From: weiyj_lk@163.com To: Linus Walleij , Ray Jui , Scott Branden , Jon Mason Cc: Wei Yongjun , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe() Date: Wed, 6 Jul 2016 12:02:51 +0000 Message-Id: <1467806571-23811-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: D8CowADXNtNr83xXTWIrCg--.2904S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxJF17JrWUCFyruF4rCw47twb_yoW8XF4UpF s3tFWS9rn8GF45G34rJw48ZF13C3WIka1rK3y0g39xZa90yryDJw4FgrW5Jrs8CFWv9r45 Jr4fJry8ZF1rWFUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jddbbUUUUU= X-Originating-IP: [49.77.207.185] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiMAye1lWBW7fbfgAAsp Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Ray Jui --- drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c index 7df0880b..4149db3 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c @@ -573,10 +573,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pinctrl->base0 = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pinctrl->base0)) { - dev_err(&pdev->dev, "unable to map I/O space\n"); + if (IS_ERR(pinctrl->base0)) return PTR_ERR(pinctrl->base0); - } res = platform_get_resource(pdev, IORESOURCE_MEM, 1); pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start, @@ -588,10 +586,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 2); pinctrl->base2 = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pinctrl->base2)) { - dev_err(&pdev->dev, "unable to map I/O space\n"); + if (IS_ERR(pinctrl->base2)) return PTR_ERR(pinctrl->base2); - } ret = nsp_mux_log_init(pinctrl); if (ret) {