diff mbox

[1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields

Message ID 1456473597.24027.0.camel@ingics.com
State New
Headers show

Commit Message

Axel Lin Feb. 26, 2016, 7:59 a.m. UTC
These fields are initialized by bgpio_init() with exactly the same settings
so remove the redundant code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-moxart.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Linus Walleij March 7, 2016, 4:37 a.m. UTC | #1
On Fri, Feb 26, 2016 at 2:59 PM, Axel Lin <axel.lin@ingics.com> wrote:

> These fields are initialized by bgpio_init() with exactly the same settings
> so remove the redundant code.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index ca60453..f7cf593 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -57,10 +57,7 @@  static int moxart_gpio_probe(struct platform_device *pdev)
 	gc->label = "moxart-gpio";
 	gc->request = gpiochip_generic_request;
 	gc->free = gpiochip_generic_free;
-	gc->bgpio_data = gc->read_reg(gc->reg_set);
 	gc->base = 0;
-	gc->ngpio = 32;
-	gc->parent = dev;
 	gc->owner = THIS_MODULE;
 
 	ret = gpiochip_add_data(gc, NULL);