| Message ID | 1456319775-3216-5-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | New |
| Headers | show |
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Ray Jui <rjui@broadcom.com> > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 0f5997c..25bc4a2 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -1027,7 +1027,7 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) > return err; > } > > - pc->pctl_dev = pinctrl_register(&bcm2835_pinctrl_desc, dev, pc); > + pc->pctl_dev = devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc); > if (IS_ERR(pc->pctl_dev)) { > gpiochip_remove(&pc->gpio_chip); > return PTR_ERR(pc->pctl_dev); > @@ -1045,7 +1045,6 @@ static int bcm2835_pinctrl_remove(struct platform_device *pdev) > { > struct bcm2835_pinctrl *pc = platform_get_drvdata(pdev); > > - pinctrl_unregister(pc->pctl_dev); > gpiochip_remove(&pc->gpio_chip); > > return 0; > Reviewed-by: Ray Jui <ray.jui@broadcom.com> Thanks! Ray -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 0f5997c..25bc4a2 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -1027,7 +1027,7 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) return err; } - pc->pctl_dev = pinctrl_register(&bcm2835_pinctrl_desc, dev, pc); + pc->pctl_dev = devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc); if (IS_ERR(pc->pctl_dev)) { gpiochip_remove(&pc->gpio_chip); return PTR_ERR(pc->pctl_dev); @@ -1045,7 +1045,6 @@ static int bcm2835_pinctrl_remove(struct platform_device *pdev) { struct bcm2835_pinctrl *pc = platform_get_drvdata(pdev); - pinctrl_unregister(pc->pctl_dev); gpiochip_remove(&pc->gpio_chip); return 0;
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Cc: Ray Jui <rjui@broadcom.com> --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)