From patchwork Mon Feb 22 12:16:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 586126 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8CDCA140BAC for ; Mon, 22 Feb 2016 23:16:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b=ZJTTw041; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbcBVMQ4 (ORCPT ); Mon, 22 Feb 2016 07:16:56 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35988 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186AbcBVMQz (ORCPT ); Mon, 22 Feb 2016 07:16:55 -0500 Received: by mail-pa0-f45.google.com with SMTP id yy13so90439214pab.3 for ; Mon, 22 Feb 2016 04:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:content-type:mime-version :content-transfer-encoding; bh=OQbWiJofKem2NZSFaky5CqKiuBQymDIy1+vH0fmenUU=; b=ZJTTw041+dCJV670UIkMZVZcIzDe/7DZIrmwb3GKsPZ91f9OkYvxDi0EKsiReLyhsL 4fqx55ZEKl1Dv3uSDySOhQP6HazBGNZFVLm1ng+6jbCRkMuEIGoaDBr2m56YBaPLwPbD 0SSXl3l8v+Q7J4V6JiZklFPQ6rN0okezQT62uOwHff4eCvn/yofmQzBOE0izmXVP4Boq VJLU8/spg0FHirQLFhsRLWYB4PNdUXk5W0u3WQHZJYsaIy2ri6PFV51Ni3eO2z+r3ab/ mYyBay0d7n1LdCVow7dnplabE1dWLpAldElbY0nn4TpojXv3NvcJKXm9Z2Z5iHtjFJkf Bgig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=OQbWiJofKem2NZSFaky5CqKiuBQymDIy1+vH0fmenUU=; b=S1XJ8naaxFj3pnewaztmqlXBSc0nhevlpb9n8UgAyq0P50IV3f3HrMyLtFLdbpsros sRkA4nE3MSlIv3spbqae5BEJs1CgC6D2XuA7kNceAmQbOO7TpWweuCeCdhxzr6wmJeDG yW9A2NMKm+BtZLRXFktglRQ52rQVgP7GHehP/XWshYGYoMD2NhLjFoUQZZ3XpJ9GANRb +qWM4Rg0djEusHol/SUAzmJdPn+u9Qys6vZzVrsfgnx9GLEQbyBVperkdb6t45SyO17c 4qr7AUlahaKanvIuPPaemYg5WA1WoD2UMKOdpq0ga6ymEDLHU01AxpgUH094eP8rMyA4 DdMw== X-Gm-Message-State: AG10YOQvVShNXz/tI3aibpWAxDZ/xk4sCRrMvbo53gG1hz7iJ+K/DP+5/WVpfisd+da04g== X-Received: by 10.66.222.199 with SMTP id qo7mr37630167pac.38.1456143415137; Mon, 22 Feb 2016 04:16:55 -0800 (PST) Received: from phoenix (36-239-243-128.dynamic-ip.hinet.net. [36.239.243.128]) by smtp.gmail.com with ESMTPSA id u90sm36539489pfa.60.2016.02.22.04.16.52 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 04:16:53 -0800 (PST) Message-ID: <1456143411.23008.1.camel@ingics.com> Subject: [PATCH] gpio: pisosr: Use devm_gpiod_get_optional for gpio->load_gpio From: Axel Lin To: Linus Walleij Cc: "Andrew F. Davis" , Alexandre Courbot , linux-gpio@vger.kernel.org Date: Mon, 22 Feb 2016 20:16:51 +0800 X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org gpio->load_gpio is optional, so use devm_gpiod_get_optional instead. Signed-off-by: Axel Lin Acked-by: Andrew F. Davis --- drivers/gpio/gpio-pisosr.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index f9f1074..8b8bf8f 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -125,15 +125,12 @@ static int pisosr_gpio_probe(struct spi_device *spi) if (!gpio->buffer) return -ENOMEM; - gpio->load_gpio = devm_gpiod_get(dev, "load", GPIOD_OUT_LOW); + gpio->load_gpio = devm_gpiod_get_optional(dev, "load", GPIOD_OUT_LOW); if (IS_ERR(gpio->load_gpio)) { ret = PTR_ERR(gpio->load_gpio); - if (ret != -ENOENT && ret != -ENOSYS) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "Unable to allocate load GPIO\n"); - return ret; - } - gpio->load_gpio = NULL; + if (ret != -EPROBE_DEFER) + dev_err(dev, "Unable to allocate load GPIO\n"); + return ret; } mutex_init(&gpio->lock);