From patchwork Tue Oct 6 12:01:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 526715 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9A1ED1402A8 for ; Tue, 6 Oct 2015 23:01:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=df6BYC7B; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbbJFMBW (ORCPT ); Tue, 6 Oct 2015 08:01:22 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36117 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbbJFMBV (ORCPT ); Tue, 6 Oct 2015 08:01:21 -0400 Received: by pacik9 with SMTP id ik9so25854040pac.3; Tue, 06 Oct 2015 05:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=t1sJvM/jCFZQ/EvayxujHp+1T58MeAY7J+wipRDxIwo=; b=df6BYC7BjeNyxGYit3g6BykZuPsZ9PQlFVdwt+9+X+mEIy1q7SXMzRlxTqczFR1Q1B 6D6vLHBcbKSTCtKGpLTi6VFu2vAGBDnbQ4o5PWGAYDrYIRTQk7aTJK1RPqniSAu1tsKL XsjnClBEEf0Za2r/UPvsSjMroPJr9qVFefFXGHkfVA87NQr7RMXhPmedrlnTnYReMxLq mnhN+AeqM4hv61E4sXnYownrHlkSF7j6NuFugnULcgityluq/0CPFa+WZNgQB7IinWXo X6VKcajKYiH9qln0cyLjrWPjgAS6/+4GBVIdnvZp4Dy9gx/Fyfeo/WqTsrP96eHK5ayq gqgA== X-Received: by 10.66.165.106 with SMTP id yx10mr47274267pab.102.1444132881006; Tue, 06 Oct 2015 05:01:21 -0700 (PDT) Received: from localhost.localdomain ([49.206.251.3]) by smtp.gmail.com with ESMTPSA id i9sm33114349pbq.84.2015.10.06.05.01.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Oct 2015 05:01:20 -0700 (PDT) From: Sudip Mukherjee To: Linus Walleij , Alexandre Courbot Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Sudip Mukherjee , Tony Lindgren , Austin Schuh , Grygorii Strashko , Santosh Shilimkar Subject: [PATCH] gpio: make GPIO_OMAP bool instead of tristate Date: Tue, 6 Oct 2015 17:31:11 +0530 Message-Id: <1444132871-25798-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org While building arm allmodconfig the build fails with the error: ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined! The build breaks as handle_bad_irq is not exported for module use. Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler") Cc: Tony Lindgren Cc: Austin Schuh Cc: Grygorii Strashko Cc: Santosh Shilimkar Signed-off-by: Sudip Mukherjee --- Same problem for pinctrl was fixed by 5ba341604a054294aeb812603349bba024d716ee And for your reference: https://lkml.org/lkml/2014/2/25/278 drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 63000b1..d910fd1 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -330,7 +330,7 @@ config GPIO_OCTEON family of SOCs. config GPIO_OMAP - tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST + bool "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST default y if ARCH_OMAP depends on ARM select GENERIC_IRQ_CHIP