From patchwork Thu Apr 9 15:18:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ivan T. Ivanov" X-Patchwork-Id: 459762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4C9591402DE for ; Fri, 10 Apr 2015 01:19:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755694AbbDIPSu (ORCPT ); Thu, 9 Apr 2015 11:18:50 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37831 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755600AbbDIPSn (ORCPT ); Thu, 9 Apr 2015 11:18:43 -0400 Received: by wiaa2 with SMTP id a2so102653628wia.0 for ; Thu, 09 Apr 2015 08:18:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gGOnbiNP44BnO15tAne4r4o12RotPHnXzyft6qDrEmI=; b=Q6Hcxn2xzt48cfS2fIBjC5UrLQgbgS429G8/TMXUN8OiQV3+0bI5lrGypPxt8Oqb/2 FvdB5k41RZvPUJ43FB0oP7qO+HT09WDXAXNP66SNxQzCeBjN+Scp6cS43MnM6mYCEgpL 4mwnIjywRcYmFHUxMZOgnOf9PReJSRxtoimZaq8OLp2lfb9LITbGyWzVu5JL9hfsSXYZ xghRpjZwKT9DeNxPUk/Vm20UmEVhf8dHr0rBvWkkM3rOl1ysY4h/m6TO41jYje2uUAH5 jy8u9D7J9aNszcuTVS2SP8nja+CbPWIa5fKOyUMkWIwtLpcrc3I+1LUFPxATFFZMALIW gsNg== X-Gm-Message-State: ALoCoQmDrGCBjMQ0fi22aJrHjasslro3LF+v8IaF8Iwfl2aRUEmAVpDa4bpLt6inwT5WA0EhTTGM X-Received: by 10.180.104.34 with SMTP id gb2mr4318498wib.95.1428592722892; Thu, 09 Apr 2015 08:18:42 -0700 (PDT) Received: from localhost.localdomain ([37.157.136.206]) by mx.google.com with ESMTPSA id ed14sm10383483wic.11.2015.04.09.08.18.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Apr 2015 08:18:42 -0700 (PDT) From: "Ivan T. Ivanov" To: Linus Walleij Cc: Bjorn Andersson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 3/3] pinctrl: qcom-spmi-mpp: Fix input value report Date: Thu, 9 Apr 2015 18:18:37 +0300 Message-Id: <1428592717-21706-3-git-send-email-ivan.ivanov@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1428592717-21706-1-git-send-email-ivan.ivanov@linaro.org> References: <1428592717-21706-1-git-send-email-ivan.ivanov@linaro.org> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix interpretation of the pmic_mpp_read() return code, negative value means an error. Signed-off-by: Ivan T. Ivanov Reviewed-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c index 8f36c5f..8f6c7be 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c @@ -576,10 +576,11 @@ static void pmic_mpp_config_dbg_show(struct pinctrl_dev *pctldev, if (pad->input_enabled) { ret = pmic_mpp_read(state, pad, PMIC_MPP_REG_RT_STS); - if (!ret) { - ret &= PMIC_MPP_REG_RT_STS_VAL_MASK; - pad->out_value = ret; - } + if (ret < 0) + return; + + ret &= PMIC_MPP_REG_RT_STS_VAL_MASK; + pad->out_value = ret; } seq_printf(s, " %-4s", pad->output_enabled ? "out" : "in");