From patchwork Tue Mar 24 18:42:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: grygorii.strashko@linaro.org X-Patchwork-Id: 453980 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 58C1814009B for ; Wed, 25 Mar 2015 05:42:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbbCXSm5 (ORCPT ); Tue, 24 Mar 2015 14:42:57 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:33173 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932111AbbCXSm4 (ORCPT ); Tue, 24 Mar 2015 14:42:56 -0400 Received: by labto5 with SMTP id to5so1505778lab.0 for ; Tue, 24 Mar 2015 11:42:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KRYMJdnVyi1uXtUw4TIV+RCqBYpylDaUkmh4VYxYRes=; b=e9ypaXvXlObD//CDT2C/NxxzYQ21G7bgCHVi5OO9W0iPm7nJbdTfZCB7GL01FmYjk1 IA9u8Nl0vS4XbVhe2ko39/oM8U3j8Pr2s8SO5AiFo001w1R/v0Rm2nYkl0Ffe7BkXs7n iUkGfuMAru7xUOMB8Kd9FCCnWC7pc/K1HRaJighd9fqm73nARJWDtGtgCC/7ZAcpDPlv vqYLGB8PRdXrpeTperL5FbSEv5OBm5xT/frSmQCIiU88vA4NNWqUopOiIZENsuDW4URF 3Ia3pCwtns/NR/lnUUmZaPe01Ia+/z97OH8vpMs1aIEPYMKwMIYDjyJp1aajYd4R0KGh MqSg== X-Gm-Message-State: ALoCoQm7+UpevQSaWZIl/0xNOJKjH7L5AAUVny5tMRhAt91yI5kh3ywpAkUe5GJt3uqDJJh3i+zh X-Received: by 10.112.183.134 with SMTP id em6mr4957485lbc.52.1427222574336; Tue, 24 Mar 2015 11:42:54 -0700 (PDT) Received: from localhost ([195.238.92.128]) by mx.google.com with ESMTPSA id i6sm25871lai.1.2015.03.24.11.42.53 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Mar 2015 11:42:53 -0700 (PDT) From: To: linux@arm.linux.org.uk, Linus Walleij , Alexandre Courbot Cc: m-karicheri2@ti.com, ssantosh@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko Subject: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt Date: Tue, 24 Mar 2015 20:42:42 +0200 Message-Id: <1427222562-2223-1-git-send-email-grygorii.strashko@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20150324161358.GA694@kahuna> References: <20150324161358.GA694@kahuna> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Grygorii Strashko Now GPIO syscon driver produces bunch of warnings during the boot of Kesytone 2 SoCs: gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset! gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset! This message unintentionally was added using dev_err(), but its actual log level is debug, because third cell of "ti,syscon-dev" is optional. Hence change it to dev_dbg() as it should be. This patch fixes commit: 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt") Reported-by: Russell King Signed-off-by: Grygorii Strashko Tested-by: Murali Karicheri Acked-by: Santosh Shilimkar --- drivers/gpio/gpio-syscon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 257e298..045a952 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -219,7 +219,7 @@ static int syscon_gpio_probe(struct platform_device *pdev) ret = of_property_read_u32_index(np, "gpio,syscon-dev", 2, &priv->dir_reg_offset); if (ret) - dev_err(dev, "can't read the dir register offset!\n"); + dev_dbg(dev, "can't read the dir register offset!\n"); priv->dir_reg_offset <<= 3; }