From patchwork Fri Mar 20 19:12:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 452753 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 429A6140140 for ; Sat, 21 Mar 2015 06:12:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbbCTTMv (ORCPT ); Fri, 20 Mar 2015 15:12:51 -0400 Received: from mout.web.de ([212.227.15.14]:61486 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbbCTTMv (ORCPT ); Fri, 20 Mar 2015 15:12:51 -0400 Received: from kongar.lan.local ([185.44.151.99]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0M9XbT-1YfLCj3upD-00CywY; Fri, 20 Mar 2015 20:12:15 +0100 From: Alexander Stein To: Jean-Christophe Plagniol-Villard , Linus Walleij Cc: Alexander Stein , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature Date: Fri, 20 Mar 2015 20:12:00 +0100 Message-Id: <1426878721-2618-1-git-send-email-alexanders83@web.de> X-Mailer: git-send-email 2.3.3 X-Provags-ID: V03:K0:Ggt3UBzHZuLjgQzs22FQQK0TAgRroTldEEq2ebsXWq/LHd+ghMO RPrXPDH5M4vNudL3ZPFsEFvuvbRs/PluCwAlrm/bcbou071dCuvaIQNuYsudwYvmw6e3u+U 3aK6wdIdvCfwuVGGyPCxeilr6Q+MomJnU7y7Z31Q9hBkRFuTGoEZzT5oQU7E1GF4ssx55sV xJ8L6M/G1iYbvTWaeABbQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This adds the callback for set_multiple. As this controller has a separate set and clear register, we can't write directly to PIO_ODSR as this would required a cached variable and would race with at91_gpio_set. So build masks for the PIO_SODR and PIO_CODR registers and write them together. Signed-off-by: Alexander Stein Acked-by: Ludovic Desroches --- This was tested by using an own test driver which uses gpiod_set_array_cansleep to set multiple GPIOs at once. drivers/pinctrl/pinctrl-at91.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index f4cd0b9..a882523 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -1330,6 +1330,33 @@ static void at91_gpio_set(struct gpio_chip *chip, unsigned offset, writel_relaxed(mask, pio + (val ? PIO_SODR : PIO_CODR)); } +static void at91_gpio_set_multiple(struct gpio_chip *chip, + unsigned long *mask, unsigned long *bits) +{ + struct at91_gpio_chip *at91_gpio = to_at91_gpio_chip(chip); + void __iomem *pio = at91_gpio->regbase; + unsigned long set_mask; + unsigned long clear_mask; + size_t i; + + set_mask = 0; + clear_mask = 0; + + for (i = 0; i < chip->ngpio; i++) { + if (*mask == 0) + break; + if (__test_and_clear_bit(i, mask)) { + if (test_bit(i, bits)) + set_mask |= BIT(i); + else + clear_mask |= BIT(i); + } + } + + writel_relaxed(set_mask, pio + PIO_SODR); + writel_relaxed(clear_mask, pio + PIO_CODR); +} + static int at91_gpio_direction_output(struct gpio_chip *chip, unsigned offset, int val) { @@ -1692,6 +1719,7 @@ static struct gpio_chip at91_gpio_template = { .get = at91_gpio_get, .direction_output = at91_gpio_direction_output, .set = at91_gpio_set, + .set_multiple = at91_gpio_set_multiple, .dbg_show = at91_gpio_dbg_show, .can_sleep = false, .ngpio = MAX_NB_GPIO_PER_BANK,