From patchwork Sun Mar 15 00:05:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 450239 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B1DF51400B7 for ; Sun, 15 Mar 2015 11:06:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=agner.ch header.i=@agner.ch header.b=wTURLXO2; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbbCOAGA (ORCPT ); Sat, 14 Mar 2015 20:06:00 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:34585 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbbCOAF7 (ORCPT ); Sat, 14 Mar 2015 20:05:59 -0400 Received: from trochilidae.agner.local (195-226-23-137.pool.cyberlink.ch [195.226.23.137]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 83F1C5C0BA4; Sun, 15 Mar 2015 01:05:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=agner.ch; s=dkim; t=1426377938; bh=fiUSc1TCv11XsU/f97fIbEEXUGpvW/W41Vznl3ZzawE=; h=From:To:Cc:Subject:Date:From; b=wTURLXO2nTZ/NL1jGYpt8FvmOtKyI9lwbgwaqKD4TOpDEKAmq86hM41hHSozKa1JN bzYYuOfOByozbCOXPok3mDtWG4088n/1Gd6DnSx7Lyy+ms1RplF64iBnxPtAfhskWi N4DBzj4MLH4H/NtWqb27M++ThnOKs1Ldl7CwgV2Q= From: Stefan Agner To: linus.walleij@linaro.org Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stefan@agner.ch Subject: [PATCH] pinctrl: tegra: use signed bitfields for optional fields Date: Sun, 15 Mar 2015 01:05:52 +0100 Message-Id: <1426377952-12383-1-git-send-email-stefan@agner.ch> X-Mailer: git-send-email 2.3.3 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Optional fields are set to -1 by various preprocessor macros. Make sure the struct fields can actually store them. Signed-off-by: Stefan Agner --- This lead to a lot of warnings when compiling the Tegra pinctrl drivers using LLVM/clang: drivers/pinctrl/pinctrl-tegra124.c:2048:2: warning: implicit truncation from 'int' to bitfield changes value from -1 to 63 [-Wbitfield-constant-conversion] MIPI_PAD_CTRL_PINGROUP(dsi_b, 0x820, 1, CSI, DSI_B) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-tegra124.c:1807:18: note: expanded from macro 'MIPI_PAD_CTRL_PINGROUP' .rcv_sel_bit = -1, \ ^~ However, I did not check if this could actually lead to an unintended pin configuration... drivers/pinctrl/pinctrl-tegra.h | 48 ++++++++++++++++++++--------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tegra.h b/drivers/pinctrl/pinctrl-tegra.h index 8d94d13..0711ae62 100644 --- a/drivers/pinctrl/pinctrl-tegra.h +++ b/drivers/pinctrl/pinctrl-tegra.h @@ -135,30 +135,30 @@ struct tegra_pingroup { s16 pupd_reg; s16 tri_reg; s16 drv_reg; - u32 mux_bank:2; - u32 pupd_bank:2; - u32 tri_bank:2; - u32 drv_bank:2; - u32 mux_bit:6; - u32 pupd_bit:6; - u32 tri_bit:6; - u32 einput_bit:6; - u32 odrain_bit:6; - u32 lock_bit:6; - u32 ioreset_bit:6; - u32 rcv_sel_bit:6; - u32 hsm_bit:6; - u32 schmitt_bit:6; - u32 lpmd_bit:6; - u32 drvdn_bit:6; - u32 drvup_bit:6; - u32 slwr_bit:6; - u32 slwf_bit:6; - u32 drvtype_bit:6; - u32 drvdn_width:6; - u32 drvup_width:6; - u32 slwr_width:6; - u32 slwf_width:6; + u8 mux_bank:2; + u8 pupd_bank:2; + u8 tri_bank:2; + u8 drv_bank:2; + s8 mux_bit:6; + s8 pupd_bit:6; + s8 tri_bit:6; + s8 einput_bit:6; + s8 odrain_bit:6; + s8 lock_bit:6; + s8 ioreset_bit:6; + s8 rcv_sel_bit:6; + s8 hsm_bit:6; + s8 schmitt_bit:6; + s8 lpmd_bit:6; + s8 drvdn_bit:6; + s8 drvup_bit:6; + s8 slwr_bit:6; + s8 slwf_bit:6; + s8 drvtype_bit:6; + s8 drvdn_width:6; + s8 drvup_width:6; + s8 slwr_width:6; + s8 slwf_width:6; }; /**