diff mbox

gpio: sx150x: Fix comparing wrong value with chip->irq_masked

Message ID 1418710947.23043.1.camel@phoenix
State New, archived
Headers show

Commit Message

Axel Lin Dec. 16, 2014, 6:22 a.m. UTC 
Fix a copy-paste bug.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-sx150x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Courbot Dec. 17, 2014, 2:27 a.m. UTC | #1 
On Tue, Dec 16, 2014 at 3:22 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix a copy-paste bug.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 13, 2015, 9:23 a.m. UTC | #2 
On Tue, Dec 16, 2014 at 7:22 AM, Axel Lin <axel.lin@ingics.com> wrote:

> Fix a copy-paste bug.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied with Alex's review tag.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-sx150x.c b/drivers/gpio/gpio-sx150x.c
index bce6c61..6e37257 100644
--- a/drivers/gpio/gpio-sx150x.c
+++ b/drivers/gpio/gpio-sx150x.c
@@ -401,7 +401,7 @@  static void sx150x_irq_bus_sync_unlock(struct irq_data *d)
 
 	/* Avoid updates if nothing changed */
 	if (chip->dev_sense == chip->irq_sense &&
-	    chip->dev_sense == chip->irq_masked)
+	    chip->dev_masked == chip->irq_masked)
 		goto out;
 
 	chip->dev_sense = chip->irq_sense;