| Message ID | 1411226071-11625-2-git-send-email-varkab@cdac.in |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sun, Sep 21, 2014 at 12:14 AM, Varka Bhadram <varkabhadram@gmail.com> wrote: > > Signed-off-by: Varka Bhadram <varkab@cdac.in> > --- > drivers/gpio/gpio-ks8695.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c > index ba2d2f1..10c7377 100644 > --- a/drivers/gpio/gpio-ks8695.c > +++ b/drivers/gpio/gpio-ks8695.c > @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused) > case IOPC_TM_EDGE: > seq_printf(s, "(Edges)"); break; > } > - } > - else > + } else > seq_printf(s, "GPIO\t"); According to the kernel code formatting guidelines, this should actually be } else { seq_printf(s, "GPIO\t"); } -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 22 September 2014 03:18 PM, Alexandre Courbot wrote: > On Sun, Sep 21, 2014 at 12:14 AM, Varka Bhadram <varkabhadram@gmail.com> wrote: >> Signed-off-by: Varka Bhadram <varkab@cdac.in> >> --- >> drivers/gpio/gpio-ks8695.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c >> index ba2d2f1..10c7377 100644 >> --- a/drivers/gpio/gpio-ks8695.c >> +++ b/drivers/gpio/gpio-ks8695.c >> @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused) >> case IOPC_TM_EDGE: >> seq_printf(s, "(Edges)"); break; >> } >> - } >> - else >> + } else >> seq_printf(s, "GPIO\t"); > According to the kernel code formatting guidelines, this should actually be > > } else { > seq_printf(s, "GPIO\t"); > } Ok i will change it . Thanks... -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c index ba2d2f1..10c7377 100644 --- a/drivers/gpio/gpio-ks8695.c +++ b/drivers/gpio/gpio-ks8695.c @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused) case IOPC_TM_EDGE: seq_printf(s, "(Edges)"); break; } - } - else + } else seq_printf(s, "GPIO\t"); - } - else if (i <= KS8695_GPIO_5) { + } else if (i <= KS8695_GPIO_5) { if (ctrl & enable[i]) seq_printf(s, "TOUT%i\t", i - KS8695_GPIO_4); else seq_printf(s, "GPIO\t"); - } - else + } else seq_printf(s, "GPIO\t"); seq_printf(s, "\t");
Signed-off-by: Varka Bhadram <varkab@cdac.in> --- drivers/gpio/gpio-ks8695.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)