| Message ID | 010e1799ddc02e5f41c2cebded47ed5478b3d7b6.1485287208.git.vilhelm.gray@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 24, 2017 at 9:01 PM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > The devm_ resource manager functions allow memory to be automatically > released when a device is unbound. This patch takes advantage of the > resource manager functions and replaces the gpiochip_add_data call with > the devm_gpiochip_add_data call. In addition, the gpiomm_remove function > has been removed as no longer necessary due to the use of the relevant > devm_ resource manager functions. > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-gpio-mm.c b/drivers/gpio/gpio-gpio-mm.c index 1e7def9449ce..c2837ce64ea3 100644 --- a/drivers/gpio/gpio-gpio-mm.c +++ b/drivers/gpio/gpio-gpio-mm.c @@ -224,7 +224,7 @@ static int gpiomm_probe(struct device *dev, unsigned int id) dev_set_drvdata(dev, gpiommgpio); - err = gpiochip_add_data(&gpiommgpio->chip, gpiommgpio); + err = devm_gpiochip_add_data(dev, &gpiommgpio->chip, gpiommgpio); if (err) { dev_err(dev, "GPIO registering failed (%d)\n", err); return err; @@ -243,21 +243,11 @@ static int gpiomm_probe(struct device *dev, unsigned int id) return 0; } -static int gpiomm_remove(struct device *dev, unsigned int id) -{ - struct gpiomm_gpio *const gpiommgpio = dev_get_drvdata(dev); - - gpiochip_remove(&gpiommgpio->chip); - - return 0; -} - static struct isa_driver gpiomm_driver = { .probe = gpiomm_probe, .driver = { .name = "gpio-mm" }, - .remove = gpiomm_remove }; module_isa_driver(gpiomm_driver, num_gpiomm);
The devm_ resource manager functions allow memory to be automatically released when a device is unbound. This patch takes advantage of the resource manager functions and replaces the gpiochip_add_data call with the devm_gpiochip_add_data call. In addition, the gpiomm_remove function has been removed as no longer necessary due to the use of the relevant devm_ resource manager functions. Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/gpio/gpio-gpio-mm.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)