mbox series

[0/3] pinctrl: don't use gpiod_to_chip()

Message ID 20231115165001.2932350-1-brgl@bgdev.pl
Headers show
Series pinctrl: don't use gpiod_to_chip() | expand

Message

Bartosz Golaszewski Nov. 15, 2023, 4:49 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Let's start working towards removing gpiod_to_chip() from the kernel.
Start with pinctrl. The first patch should go through the GPIO tree
and become available through an immutable tag so that we can get more
conversions in this cycle elsewhere.

Bartosz Golaszewski (3):
  gpiolib: provide gpio_devie_get_label()
  pinctrl: stop using gpiod_to_chip()
  pinctrl: don't include GPIOLIB private header

 drivers/gpio/gpiolib.c      | 14 ++++++++++++++
 drivers/pinctrl/core.c      | 18 ++++++++----------
 include/linux/gpio/driver.h |  1 +
 3 files changed, 23 insertions(+), 10 deletions(-)

Comments

Linus Walleij Nov. 16, 2023, 1:43 p.m. UTC | #1
On Wed, Nov 15, 2023 at 5:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Let's start working towards removing gpiod_to_chip() from the kernel.
> Start with pinctrl. The first patch should go through the GPIO tree
> and become available through an immutable tag so that we can get more
> conversions in this cycle elsewhere.

Fair enough, maybe an immutable branch with all three patches?
Probably best to merga all three into both subsystems I think.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Nov. 20, 2023, 3:06 p.m. UTC | #2
On Thu, Nov 16, 2023 at 2:43 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Nov 15, 2023 at 5:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Let's start working towards removing gpiod_to_chip() from the kernel.
> > Start with pinctrl. The first patch should go through the GPIO tree
> > and become available through an immutable tag so that we can get more
> > conversions in this cycle elsewhere.
>
> Fair enough, maybe an immutable branch with all three patches?
> Probably best to merga all three into both subsystems I think.
>

Nah, I don't think I need to pollute the GPIO tree with every pinctrl
patch. It's enough to just merge the first one into GPIO and you do
the same in pinctrl.

Bart

> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
Linus Walleij Nov. 24, 2023, 10:01 a.m. UTC | #3
On Mon, Nov 20, 2023 at 4:06 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Thu, Nov 16, 2023 at 2:43 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Wed, Nov 15, 2023 at 5:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Let's start working towards removing gpiod_to_chip() from the kernel.
> > > Start with pinctrl. The first patch should go through the GPIO tree
> > > and become available through an immutable tag so that we can get more
> > > conversions in this cycle elsewhere.
> >
> > Fair enough, maybe an immutable branch with all three patches?
> > Probably best to merga all three into both subsystems I think.
> >
>
> Nah, I don't think I need to pollute the GPIO tree with every pinctrl
> patch. It's enough to just merge the first one into GPIO and you do
> the same in pinctrl.

Fair enough, but I need that immutable branch for patch 1 so I
can merge the rest on top.

Yours,
Linus Walleij
Bartosz Golaszewski Nov. 24, 2023, 7:40 p.m. UTC | #4
On Fri, Nov 24, 2023 at 11:01 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Nov 20, 2023 at 4:06 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > On Thu, Nov 16, 2023 at 2:43 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > On Wed, Nov 15, 2023 at 5:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > Let's start working towards removing gpiod_to_chip() from the kernel.
> > > > Start with pinctrl. The first patch should go through the GPIO tree
> > > > and become available through an immutable tag so that we can get more
> > > > conversions in this cycle elsewhere.
> > >
> > > Fair enough, maybe an immutable branch with all three patches?
> > > Probably best to merga all three into both subsystems I think.
> > >
> >
> > Nah, I don't think I need to pollute the GPIO tree with every pinctrl
> > patch. It's enough to just merge the first one into GPIO and you do
> > the same in pinctrl.
>
> Fair enough, but I need that immutable branch for patch 1 so I
> can merge the rest on top.
>
> Yours,
> Linus Walleij

I applied the first patch (after fixing the typo in the commit
message) and sent you the immutable branch to pull. Please apply the
remaining patches to the pinctrl tree directly.

Thanks!
Bart
Linus Walleij Nov. 24, 2023, 11:29 p.m. UTC | #5
On Fri, Nov 24, 2023 at 8:40 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Fri, Nov 24, 2023 at 11:01 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Mon, Nov 20, 2023 at 4:06 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > On Thu, Nov 16, 2023 at 2:43 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > > On Wed, Nov 15, 2023 at 5:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > > >
> > > > > Let's start working towards removing gpiod_to_chip() from the kernel.
> > > > > Start with pinctrl. The first patch should go through the GPIO tree
> > > > > and become available through an immutable tag so that we can get more
> > > > > conversions in this cycle elsewhere.
> > > >
> > > > Fair enough, maybe an immutable branch with all three patches?
> > > > Probably best to merga all three into both subsystems I think.
> > > >
> > >
> > > Nah, I don't think I need to pollute the GPIO tree with every pinctrl
> > > patch. It's enough to just merge the first one into GPIO and you do
> > > the same in pinctrl.
> >
> > Fair enough, but I need that immutable branch for patch 1 so I
> > can merge the rest on top.
> >
> > Yours,
> > Linus Walleij
>
> I applied the first patch (after fixing the typo in the commit
> message) and sent you the immutable branch to pull. Please apply the
> remaining patches to the pinctrl tree directly.

Pulled it and applied the other two patches on top, thanks!

Yours,
Linus Walleij