| Message ID | 20210408145601.68651-1-andriy.shevchenko@linux.intel.com |
|---|---|
| Headers | show |
| Series | gpio: xilinx: convert to use bitmap API | expand |
On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The change in the series has been inspired by [1], which, I think, > can be improved. Here I present the view how it can be done. > > The series marked as RFT since I have no hardware and I perform > compile test only. > > The patches 1 and 2 can be (independently) applied for v5.13, but I'm not in > hurry with the series, due to above (lack of real testing). So I'm flexible in > a way how it can be proceed. > > [1]: cover.1617380819.git.syednwaris@gmail.com > > Andy Shevchenko (5): > bitmap: Make bitmap_remap() and bitmap_bitremap() available to users > gpio: xilinx: Correct kernel doc for xgpio_probe() > gpio: xilinx: Introduce xgpio_read_chan() / xgpio_write_chan() > gpio: xilinx: Switch to use bitmap APIs > gpio: xilinx: No need to disable IRQs in the handler > > drivers/gpio/gpio-xilinx.c | 377 ++++++++++++++++++------------------- > lib/bitmap.c | 5 +- > 2 files changed, 190 insertions(+), 192 deletions(-) > > -- > 2.30.2 > I usually trust Andy with his work but is there any chance we can get a Tested-by before the merge window? Bart
On Fri, Apr 23, 2021 at 10:41:26PM +0200, Bartosz Golaszewski wrote: > On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > The change in the series has been inspired by [1], which, I think, > > can be improved. Here I present the view how it can be done. > > > > The series marked as RFT since I have no hardware and I perform > > compile test only. > > > > The patches 1 and 2 can be (independently) applied for v5.13, but I'm not in > > hurry with the series, due to above (lack of real testing). So I'm flexible in > > a way how it can be proceed. > > > > [1]: cover.1617380819.git.syednwaris@gmail.com > I usually trust Andy with his work but is there any chance we can get > a Tested-by before the merge window? I'm not in hurry with this and I really want to have a confirmation on this before we proceed. I may send a v2 RFT after v5.13-rc1 is out. Note TWIMC that the series has an additional followup fix that I sent separately (it's properly linked to the thread nevertheless).
On Fri, Apr 23, 2021 at 10:41:26PM +0200, Bartosz Golaszewski wrote: > On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > The change in the series has been inspired by [1], which, I think, > > can be improved. Here I present the view how it can be done. > > > > The series marked as RFT since I have no hardware and I perform > > compile test only. > > > > The patches 1 and 2 can be (independently) applied for v5.13, but I'm not in > > hurry with the series, due to above (lack of real testing). So I'm flexible in > > a way how it can be proceed. > > bitmap: Make bitmap_remap() and bitmap_bitremap() available to users > > gpio: xilinx: Correct kernel doc for xgpio_probe() Bart, thanks for the warm words, just pointing out that patches 1 and 2 has been reviewed and may be applied for v5.13 cycle. Up to you. > I usually trust Andy with his work but is there any chance we can get > a Tested-by before the merge window?
Hi Bartosz, > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Saturday, April 24, 2021 4:45 PM > To: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Cc: linux-gpio <linux-gpio@vger.kernel.org>; arm-soc <linux-arm- > kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; > Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas Neeli > <sneeli@xilinx.com>; Michal Simek <michals@xilinx.com>; Linus Walleij > <linus.walleij@linaro.org>; Yury Norov <yury.norov@gmail.com>; Rasmus > Villemoes <linux@rasmusvillemoes.dk>; Syed Nayyar Waris > <syednwaris@gmail.com>; William Breathitt Gray <vilhelm.gray@gmail.com> > Subject: Re: [RFT, PATCH v1 0/5] gpio: xilinx: convert to use bitmap API > > On Fri, Apr 23, 2021 at 10:41:26PM +0200, Bartosz Golaszewski wrote: > > On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > The change in the series has been inspired by [1], which, I think, > > > can be improved. Here I present the view how it can be done. > > > > > > The series marked as RFT since I have no hardware and I perform > > > compile test only. > > > > > > The patches 1 and 2 can be (independently) applied for v5.13, but > > > I'm not in hurry with the series, due to above (lack of real > > > testing). So I'm flexible in a way how it can be proceed. > > > > bitmap: Make bitmap_remap() and bitmap_bitremap() available to > users > > > gpio: xilinx: Correct kernel doc for xgpio_probe() > > Bart, thanks for the warm words, just pointing out that patches 1 and 2 has > been reviewed and may be applied for v5.13 cycle. Up to you. > > > I usually trust Andy with his work but is there any chance we can get > > a Tested-by before the merge window? Patches tested. Functionality working fine. Tested-by: Neeli Srinivas <sneeli@xilinx.com> > > -- > With Best Regards, > Andy Shevchenko >
On Thu, Apr 29, 2021 at 5:00 PM Srinivas Neeli <sneeli@xilinx.com> wrote: > > Hi Bartosz, > > > -----Original Message----- > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Saturday, April 24, 2021 4:45 PM > > To: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Cc: linux-gpio <linux-gpio@vger.kernel.org>; arm-soc <linux-arm- > > kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; > > Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas Neeli > > <sneeli@xilinx.com>; Michal Simek <michals@xilinx.com>; Linus Walleij > > <linus.walleij@linaro.org>; Yury Norov <yury.norov@gmail.com>; Rasmus > > Villemoes <linux@rasmusvillemoes.dk>; Syed Nayyar Waris > > <syednwaris@gmail.com>; William Breathitt Gray <vilhelm.gray@gmail.com> > > Subject: Re: [RFT, PATCH v1 0/5] gpio: xilinx: convert to use bitmap API > > > > On Fri, Apr 23, 2021 at 10:41:26PM +0200, Bartosz Golaszewski wrote: > > > On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > The change in the series has been inspired by [1], which, I think, > > > > can be improved. Here I present the view how it can be done. > > > > > > > > The series marked as RFT since I have no hardware and I perform > > > > compile test only. > > > > > > > > The patches 1 and 2 can be (independently) applied for v5.13, but > > > > I'm not in hurry with the series, due to above (lack of real > > > > testing). So I'm flexible in a way how it can be proceed. > > > > > > bitmap: Make bitmap_remap() and bitmap_bitremap() available to > > users > > > > gpio: xilinx: Correct kernel doc for xgpio_probe() > > > > Bart, thanks for the warm words, just pointing out that patches 1 and 2 has > > been reviewed and may be applied for v5.13 cycle. Up to you. > > > > > I usually trust Andy with his work but is there any chance we can get > > > a Tested-by before the merge window? > > Patches tested. Functionality working fine. > > Tested-by: Neeli Srinivas <sneeli@xilinx.com> Thank you very much! I'll send a v2 with your tags after v5.13-rc1 is out.