| Message ID | 20251208033606.10647-1-vulab@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show
Return-Path: <linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org; envelope-from=linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:21b9:f100::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dPnqs5NwNz1xq8 for <incoming@patchwork.ozlabs.org>; Mon, 08 Dec 2025 14:42:49 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dPnqs3y1rz2yFX for <incoming@patchwork.ozlabs.org>; Mon, 08 Dec 2025 14:42:49 +1100 (AEDT) X-Original-To: linux-fsi@lists.ozlabs.org Delivered-To: linux-fsi@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765165368; cv=none; b=B6ZTim6GictnAtDnvAwpi5ih/bEHkeHxSqxv7ePJOoQrVx2RFrx9eUA3qQV2NXvlR37dpa54Ui2sFkEMnOT+xyBYo2GXHyHRWVLyXCyTwhqlisQrtRlxCi8s/ZdARZ4mltGEfklbWLgPyovnEt2oxOP9WjVosuqg7gC6/fPWDZr24CV4909vrrg8mh4YbWub3lkwptoFaFRsUErmQwQy7Dp8Oot4ArMyEd9Y32dg5Yq+b67WxODSicffj2tyZoI0VHd+zTjT6+tGKymoNt0yqSlDvYoDIHNz+0m6ET+pT4ygfUBuF+9jGHDQ2S1V7p9CxiJtlIB/iP7KknYiWsY6LA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765165368; c=relaxed/relaxed; bh=OMR0A3EnJCH5I+k8P825ErHBYh5yyNnxStLU/vEJiSk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JL/AKYbTE0aS1vWdd81t+OF5Ypp8Qx5DXqs5OA59o+Gvr2KJ7AjRFHEHg/2ShmOacv8ciTTePYuiEI+vrDKVVjn4aATwourECE6sSn5M/8y0JZPdztM1UPEDaBuWOpGrAcq33tUa0DuGvuLtqQcv1aHET9+5wA62U3TPYoUH+v3tiXk9I0P/HcCDR8EGfaZSkXp1og85HY3wZMQo+QUCzUKty7QQWMhldRFzxqcHvJDxw6RNW2V7i/LKIfA+RLZqI1Ol02IkMkTmV5zEaHv3M4WKYZyLW3BGHYjdKjfXJpRyGgDUcP7R4khRndx6HS7/r6UFftpUBQSvE77kylOWow== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass (client-ip=159.226.251.81; helo=cstnet.cn; envelope-from=vulab@iscas.ac.cn; receiver=lists.ozlabs.org) smtp.mailfrom=iscas.ac.cn Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=iscas.ac.cn (client-ip=159.226.251.81; helo=cstnet.cn; envelope-from=vulab@iscas.ac.cn; receiver=lists.ozlabs.org) X-Greylist: delayed 389 seconds by postgrey-1.37 at boromir; Mon, 08 Dec 2025 14:42:47 AEDT Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dPnqq2QPkz2yDM for <linux-fsi@lists.ozlabs.org>; Mon, 08 Dec 2025 14:42:46 +1100 (AEDT) Received: from dfae2b116770.home.arpa (unknown [124.16.138.129]) by APP-03 (Coremail) with SMTP id rQCowABH2NqsRzZpQkGGAw--.10984S2; Mon, 08 Dec 2025 11:36:12 +0800 (CST) From: Wentao Liang <vulab@iscas.ac.cn> To: eajames@linux.ibm.com, ninad@linux.ibm.com Subject: [PATCH] fsi: master-gpio: Fix reference count leak in probe error path Date: Mon, 8 Dec 2025 03:36:06 +0000 Message-Id: <20251208033606.10647-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowABH2NqsRzZpQkGGAw--.10984S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtr17Gry7tFy5CrWkCF4Uurg_yoWDXrcEkF 18WF97X3yUCF1DGrs0yrWavrZFgr9xWFZ7GFykta1Sqw18AryYqF1avrs5J3WrXr4fJFsY yr97Gw1fWr43ZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbsxFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU AVWUtwCY02Avz4vE14v_Gr4l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x0JUoKZXUUUUU= X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAYKA2k2L0FkiAAAse X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=disabled version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org X-BeenThere: linux-fsi@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-fsi.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/linux-fsi>, <mailto:linux-fsi-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/linux-fsi/> List-Post: <mailto:linux-fsi@lists.ozlabs.org> List-Help: <mailto:linux-fsi-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/linux-fsi>, <mailto:linux-fsi-request@lists.ozlabs.org?subject=subscribe> Cc: Wentao Liang <vulab@iscas.ac.cn>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-fsi@lists.ozlabs.org Errors-To: linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "linux-fsi" <linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
| Series |
fsi: master-gpio: Fix reference count leak in probe error path
|
expand
|
diff --git a/drivers/fsi/fsi-master-gpio.c b/drivers/fsi/fsi-master-gpio.c index 69de0b5b9cbd..ae9e156284d0 100644 --- a/drivers/fsi/fsi-master-gpio.c +++ b/drivers/fsi/fsi-master-gpio.c @@ -861,6 +861,7 @@ static int fsi_master_gpio_probe(struct platform_device *pdev) } return 0; err_free: + of_node_put(master->master.dev.of_node); kfree(master); return rc; }
The function of_node_get() returns a node pointer with its refcount incremented, but in the error path of the fsi_master_gpio_probe(), this reference is not released before freeing the master structure, causing a refcount leak. Add the missing of_node_put() in the error handling path to properly release the device tree node reference. Fixes: 8ef9ccf81044 ("fsi: master-gpio: Add missing release function") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> --- drivers/fsi/fsi-master-gpio.c | 1 + 1 file changed, 1 insertion(+)