| Message ID | 20250731-dt-fsi-cleanups-v1-1-e7b695a29fc3@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ASpeed FSI DT clean-ups | expand |
On 7/31/25 17:12, Rob Herring (Arm) wrote: > The "no-gpios-delays" property only applies to the "fsi-master-gpio" > binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It > doesn't really make sense either as the timing is controlled by the > offloaded firmware. Thanks for the series Rob. It's fine with me if you take the bindings (we're not using the FSI tree now, Grek just merges stuff as needed) Acked-by: Eddie James <eajames@linux.ibm.com> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 - > arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 1 - > arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts > index 78a5656ef75d..f42254ba6aeb 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts > @@ -57,7 +57,6 @@ fsi: gpio-fsi { > compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; > #address-cells = <2>; > #size-cells = <0>; > - no-gpio-delays; > > memory-region = <&coldfire_memory>; > aspeed,sram = <&sram>; > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts > index b1d0ff85d397..e5b8d07e7622 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts > @@ -80,7 +80,6 @@ fsi: gpio-fsi { > compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; > #address-cells = <2>; > #size-cells = <0>; > - no-gpio-delays; > > memory-region = <&coldfire_memory>; > aspeed,sram = <&sram>; > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts > index 24df24ad9c80..2180fa9b6f24 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts > @@ -71,7 +71,6 @@ fsi: gpio-fsi { > compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; > #address-cells = <2>; > #size-cells = <0>; > - no-gpio-delays; > > memory-region = <&coldfire_memory>; > aspeed,sram = <&sram>; >
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts index 78a5656ef75d..f42254ba6aeb 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts @@ -57,7 +57,6 @@ fsi: gpio-fsi { compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; #address-cells = <2>; #size-cells = <0>; - no-gpio-delays; memory-region = <&coldfire_memory>; aspeed,sram = <&sram>; diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts index b1d0ff85d397..e5b8d07e7622 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts @@ -80,7 +80,6 @@ fsi: gpio-fsi { compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; #address-cells = <2>; #size-cells = <0>; - no-gpio-delays; memory-region = <&coldfire_memory>; aspeed,sram = <&sram>; diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts index 24df24ad9c80..2180fa9b6f24 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts @@ -71,7 +71,6 @@ fsi: gpio-fsi { compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; #address-cells = <2>; #size-cells = <0>; - no-gpio-delays; memory-region = <&coldfire_memory>; aspeed,sram = <&sram>;
The "no-gpios-delays" property only applies to the "fsi-master-gpio" binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It doesn't really make sense either as the timing is controlled by the offloaded firmware. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 - arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 1 - arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 1 - 3 files changed, 3 deletions(-)