Message ID | 20240215220759.976998-8-eajames@linux.ibm.com |
---|---|
State | New |
Headers | show |
Series | fsi: Interrupt support | expand |
On 2/16/24 02:08, Krzysztof Kozlowski wrote: > On 15/02/2024 23:07, Eddie James wrote: >> Now that the driver doesn't hardcode the clock divider, set it >> in the device tree. >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> --- >> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts | 1 + >> arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 1 + >> 2 files changed, 2 insertions(+) > Please do not mix DTS patches with driver code. DTS goes to the end > because driver code CANNOT depend on it (there are exceptions but it was > not explained here). Sure, I didn't realize. Thanks. Eddie > > Best regards, > Krzysztof >
On Sat, 17 Feb 2024 at 05:44, Eddie James <eajames@linux.ibm.com> wrote: > > > On 2/16/24 02:08, Krzysztof Kozlowski wrote: > > On 15/02/2024 23:07, Eddie James wrote: > >> Now that the driver doesn't hardcode the clock divider, set it > >> in the device tree. > >> > >> Signed-off-by: Eddie James <eajames@linux.ibm.com> > >> --- > >> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts | 1 + > >> arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 1 + > >> 2 files changed, 2 insertions(+) > > Please do not mix DTS patches with driver code. DTS goes to the end > > because driver code CANNOT depend on it (there are exceptions but it was > > not explained here). No, this is fine. Please continue sending the patches in logical order as you see fit.
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts index 213023bc5aec..96a8f727bc38 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts @@ -193,6 +193,7 @@ &fsim0 { #address-cells = <2>; #size-cells = <0>; + clock-frequency = <100000000>; fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>; fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi index cc466910bb52..a93a241d005a 100644 --- a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi +++ b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi @@ -8,6 +8,7 @@ &fsim0 { #size-cells = <0>; cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_HIGH>; + clock-frequency = <100000000>; cfam@0,0 { reg = <0 0>;
Now that the driver doesn't hardcode the clock divider, set it in the device tree. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts | 1 + arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 1 + 2 files changed, 2 insertions(+)