diff mbox series

fsi: check ida_simple_get() return value

Message ID 20220907081642.6599-1-liubo03@inspur.com
State New
Headers show
Series fsi: check ida_simple_get() return value | expand

Commit Message

Bo Liu Sept. 7, 2022, 8:16 a.m. UTC 
As ida_simple_get() can fail, we should check the return value.

Signed-off-by: Bo Liu <liubo03@inspur.com>
---
 drivers/fsi/fsi-core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 0d11a17c53a0..c009c9b30ba1 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -1313,7 +1313,10 @@  int fsi_master_register(struct fsi_master *master)
 	struct device_node *np;
 
 	mutex_init(&master->scan_lock);
-	master->idx = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
+	rc = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
+	if (rc < 0)
+		return rc;
+	master->idx = rc;
 	dev_set_name(&master->dev, "fsi%d", master->idx);
 	master->dev.class = &fsi_master_class;