| Message ID | 20220511115739.52836-1-linmq006@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | fsi: master-ast-cf: Fix refcount leak in fsi_master_acf_probe | expand |
diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c index 24292acdbaf8..3e6cacdc1bfe 100644 --- a/drivers/fsi/fsi-master-ast-cf.c +++ b/drivers/fsi/fsi-master-ast-cf.c @@ -1326,10 +1326,12 @@ static int fsi_master_acf_probe(struct platform_device *pdev) if (IS_ERR(master->cvic)) { rc = PTR_ERR(master->cvic); dev_err(&pdev->dev, "Error %d mapping CVIC\n", rc); + of_node_put(np); goto err_free; } rc = of_property_read_u32(np, "copro-sw-interrupts", &master->cvic_sw_irq); + of_node_put(np); if (rc) { dev_err(&pdev->dev, "Can't find coprocessor SW interrupt\n"); goto err_free;
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/fsi/fsi-master-ast-cf.c | 2 ++ 1 file changed, 2 insertions(+)