From patchwork Wed Jan 26 23:57:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Guang X-Patchwork-Id: 1587014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=JVlZvzaG; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JnjQ86bJmz9sFq for ; Tue, 1 Feb 2022 09:28:32 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JnjQ853yFz3bTy for ; Tue, 1 Feb 2022 09:28:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=JVlZvzaG; dkim-atps=neutral X-Original-To: linux-fsi@lists.ozlabs.org Delivered-To: linux-fsi@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::636; helo=mail-pl1-x636.google.com; envelope-from=davidcomponentone@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=JVlZvzaG; dkim-atps=neutral Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JkgdQ27Sbz2yK2 for ; Thu, 27 Jan 2022 10:57:44 +1100 (AEDT) Received: by mail-pl1-x636.google.com with SMTP id d1so991437plh.10 for ; Wed, 26 Jan 2022 15:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aKDJjrxw99oaoGuyysDvfB2GBHozPwxZDO5K9D5Zwlo=; b=JVlZvzaGbk5Kh3oX3SgJL9OdKPOpg8MmZJPCl0V43218KTTRvE/FXF/bz2FwhwgROo 1pbAcoufXGeqNAS7IsLS20/8w0eo0snQsrBTr2o0zEJe6zLlBPsPNDSL0l/Ea0E7Uhx3 EW48vhsDEUGnBQY0IwwTSv2N50UXHbdjcXuu5m5vktRPK5ycCGb69geMjtozDAQMI+nR 9siWzcu/q8I6QbfUputbNeS/Hj1Jb4NrGg7EIZo4ZinaFpIKvEUEe8AtRmKRJK/FwRLP AGgzTXR6BpnxNXgX0x66elkTwqUF8YwLPkaWXSPE4aN9LL3VmF4hsPjsXSXMWqYf9d0/ /FfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aKDJjrxw99oaoGuyysDvfB2GBHozPwxZDO5K9D5Zwlo=; b=yxMp2i73xDQKg/JhTD5ZQmic1gCaga86/QHGsGj3FXaczJO1qYug3Ng9AA+ygcLg/h Ap4LKqNzJtSwHGfYJ2SYxJ04HcW1OTnSpFeuvg0IQDK21FJ9PfbX59yLuSVnixLXsccP VPld/HixDx2SYDf3wRLh/81RwGLy7OwKqS2mq00/dpjL3VjgqrggGLu69gac1laobSrG NvmYJTKMZfsAbZ6cr7I7s6hdiOyaKEqOhTkdzCxW0Q9LX2nhwLkyol5evFAIwmNnjfAN G9GYu6G7dE1xLmLWqu6xlzVPNqdLNAN5z3WAgT5wbJTAmsiBvoltWMsOn+KLpk2jWcB6 3WCQ== X-Gm-Message-State: AOAM530+yxsp7wWI1uVR116lqeFqaRMefXTWiRp2kPVUi03+RahPdSO3 gQdDvPY2UqnchFuyGVNfUTU= X-Google-Smtp-Source: ABdhPJwzgqWb0mqT6jUi/+qs1jAD9USgSpE2wrj5W8iphk9NJCE8wbjq+XwuqUW9r/7vWK4+uYK/rQ== X-Received: by 2002:a17:902:6a82:: with SMTP id n2mr731804plk.129.1643241461123; Wed, 26 Jan 2022 15:57:41 -0800 (PST) Received: from localhost.localdomain (192.243.120.23.16clouds.com. [192.243.120.23]) by smtp.gmail.com with ESMTPSA id f8sm3465701pfj.177.2022.01.26.15.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 15:57:40 -0800 (PST) From: davidcomponentone@gmail.com To: jk@ozlabs.org Subject: [PATCH] fsi: master-ast-cf: replace snprintf with sysfs_emit Date: Thu, 27 Jan 2022 07:57:28 +0800 Message-Id: <07ad7a3621b9f92e291710ec58225a5e4580a46e.1643183118.git.yang.guang5@zte.com.cn> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 01 Feb 2022 09:27:10 +1100 X-BeenThere: linux-fsi@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@popple.id.au, Zeal Robot , davidcomponentone@gmail.com, linux-kernel@vger.kernel.org, Yang Guang , linux-fsi@lists.ozlabs.org Errors-To: linux-fsi-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "linux-fsi" From: Yang Guang coccinelle report: ./drivers/fsi/fsi-master-ast-cf.c:1086:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot Signed-off-by: Yang Guang Signed-off-by: David Yang --- drivers/fsi/fsi-master-ast-cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c index 24292acdbaf8..e33c1cfb44cd 100644 --- a/drivers/fsi/fsi-master-ast-cf.c +++ b/drivers/fsi/fsi-master-ast-cf.c @@ -1083,7 +1083,7 @@ static ssize_t external_mode_show(struct device *dev, { struct fsi_master_acf *master = dev_get_drvdata(dev); - return snprintf(buf, PAGE_SIZE - 1, "%u\n", + return sysfs_emit(buf, "%u\n", master->external_mode ? 1 : 0); }