diff mbox series

ext4: fix typos in ext4_mb_regular_allocator() comment

Message ID d6514145-73b3-808b-ec5a-a8be27c51f9c@gmail.com
State Awaiting Upstream
Headers show
Series ext4: fix typos in ext4_mb_regular_allocator() comment | expand

Commit Message

brookxu Aug. 7, 2020, 2:01 p.m. UTC
Fix typos in ext4_mb_regular_allocator() comment

Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
 fs/ext4/mballoc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Dilger Aug. 13, 2020, 8:20 a.m. UTC | #1
> On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@gmail.com> wrote:
> 
> Fix typos in ext4_mb_regular_allocator() comment
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/mballoc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4f21f34..0edec26 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
> 		goto out;
> 
> 	/*
> -	 * ac->ac2_order is set only if the fe_len is a power of 2
> -	 * if ac2_order is set we also set criteria to 0 so that we
> +	 * ac->ac_2order is set only if the fe_len is a power of 2
> +	 * if ac->ac_2order is set we also set criteria to 0 so that we
> 	 * try exact allocation using buddy.
> 	 */
> 	i = fls(ac->ac_g_ex.fe_len);
> --
> 1.8.3.1


Cheers, Andreas
Ritesh Harjani Aug. 13, 2020, 1:55 p.m. UTC | #2
On 8/7/20 7:31 PM, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Looks good to me.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
Theodore Ts'o Aug. 18, 2020, 6:14 p.m. UTC | #3
On Fri, Aug 07, 2020 at 10:01:23PM +0800, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Thanks, applied.

					- Ted
diff mbox series

Patch

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 4f21f34..0edec26 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2237,8 +2237,8 @@  static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
 		goto out;
 
 	/*
-	 * ac->ac2_order is set only if the fe_len is a power of 2
-	 * if ac2_order is set we also set criteria to 0 so that we
+	 * ac->ac_2order is set only if the fe_len is a power of 2
+	 * if ac->ac_2order is set we also set criteria to 0 so that we
 	 * try exact allocation using buddy.
 	 */
 	i = fls(ac->ac_g_ex.fe_len);