| Message ID | cf9babe1f24507d31886d806053dd1b93f2d144b.1623651783.git.riteshh@linux.ibm.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | 64K blocksize related fixes | expand |
On Mon, Jun 14, 2021 at 11:58:06AM +0530, Ritesh Harjani wrote: > Observed occasional failure of this test sometimes say with 64k config > and small device size. Reason is we were grepping for wrong values for > inode and block bitmap. > > Correct those values according to [1] to fix this test. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/fsmap.h#n53 > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> > --- > tests/ext4/027 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ext4/027 b/tests/ext4/027 > index 97c14cf5..83d5a413 100755 > --- a/tests/ext4/027 > +++ b/tests/ext4/027 > @@ -45,11 +45,11 @@ x=$(grep -c 'static fs metadata' $TEST_DIR/fsmap) > test $x -gt 0 || echo "No fs metadata?" > > echo "Check block bitmap" | tee -a $seqres.full > -x=$(grep -c 'special 102:1' $TEST_DIR/fsmap) > +x=$(grep -c 'special 102:3' $TEST_DIR/fsmap) > test $x -gt 0 || echo "No block bitmaps?" > > echo "Check inode bitmap" | tee -a $seqres.full > -x=$(grep -c 'special 102:2' $TEST_DIR/fsmap) > +x=$(grep -c 'special 102:4' $TEST_DIR/fsmap) Maaaaybe I should have added textual descriptions for the ext4 getfsmap owners. Sorry... :( Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > test $x -gt 0 || echo "No inode bitmaps?" > > echo "Check inodes" | tee -a $seqres.full > -- > 2.31.1 >
diff --git a/tests/ext4/027 b/tests/ext4/027 index 97c14cf5..83d5a413 100755 --- a/tests/ext4/027 +++ b/tests/ext4/027 @@ -45,11 +45,11 @@ x=$(grep -c 'static fs metadata' $TEST_DIR/fsmap) test $x -gt 0 || echo "No fs metadata?" echo "Check block bitmap" | tee -a $seqres.full -x=$(grep -c 'special 102:1' $TEST_DIR/fsmap) +x=$(grep -c 'special 102:3' $TEST_DIR/fsmap) test $x -gt 0 || echo "No block bitmaps?" echo "Check inode bitmap" | tee -a $seqres.full -x=$(grep -c 'special 102:2' $TEST_DIR/fsmap) +x=$(grep -c 'special 102:4' $TEST_DIR/fsmap) test $x -gt 0 || echo "No inode bitmaps?" echo "Check inodes" | tee -a $seqres.full
Observed occasional failure of this test sometimes say with 64k config and small device size. Reason is we were grepping for wrong values for inode and block bitmap. Correct those values according to [1] to fix this test. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/fsmap.h#n53 Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> --- tests/ext4/027 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)