diff mbox

missing unlock in ext2_quota_write()

Message ID alpine.DEB.2.00.0904070844220.820@bicker
State Not Applicable, archived
Headers show

Commit Message

Dan Carpenter April 7, 2009, 7:52 a.m. UTC 
The inode->i_mutex should be unlocked.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jan Kara April 9, 2009, 4:09 p.m. UTC | #1 
> The inode->i_mutex should be unlocked.
> 
> Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
  Thanks for the fix. Merged into quota tree.

								Honza
> 
> --- orig/fs/ext2/super.c	2009-04-07 08:42:15.000000000 +0300
> +++ devel/fs/ext2/super.c	2009-04-07 08:43:19.000000000 +0300
> @@ -1394,8 +1394,10 @@
>  		blk++;
>  	}
>  out:
> -	if (len == towrite)
> +	if (len == towrite) {
> +		mutex_unlock(&inode->i_mutex);
>  		return err;
> +	}
>  	if (inode->i_size < off+len-towrite)
>  		i_size_write(inode, off+len-towrite);
>  	inode->i_version++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- orig/fs/ext2/super.c	2009-04-07 08:42:15.000000000 +0300
+++ devel/fs/ext2/super.c	2009-04-07 08:43:19.000000000 +0300
@@ -1394,8 +1394,10 @@ 
 		blk++;
 	}
 out:
-	if (len == towrite)
+	if (len == towrite) {
+		mutex_unlock(&inode->i_mutex);
 		return err;
+	}
 	if (inode->i_size < off+len-towrite)
 		i_size_write(inode, off+len-towrite);
 	inode->i_version++;