| Message ID | 4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ext4: do not commit super on read-only bdev | expand |
On Mar 18, 2020, at 1:19 PM, Eric Sandeen <sandeen@sandeen.net> wrote: > > From: Eric Sandeen <sandeen@redhat.com> > > Under some circumstances we may encounter a filesystem error on a > read-only block device, and if we try to save the error info to the > superblock and commit it, we'll wind up with a noisy error and > backtrace, i.e.: > > [ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode # > ------------[ cut here ]------------ > generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2) > WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0 > ... > > To avoid this, commit the error info in the superblock only if the > block device is writable. > > Reported-by: Ritesh Harjani <riteshh@linux.ibm.com> > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Andreas Dilger <adilger@dilger.ca> > --- > > (compile-tested only FWIW) > (also, not sure if the bdev test in __save_error_info should be removed?) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 0c7c4adb664e..55392903bda5 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -372,7 +372,8 @@ static void save_error_info(struct super_block *sb, const char *func, > unsigned int line) > { > __save_error_info(sb, func, line); > - ext4_commit_super(sb, 1); > + if (!bdev_read_only(sb->s_bdev)) > + ext4_commit_super(sb, 1); > } > > /* Cheers, Andreas
On Wed, Mar 18, 2020 at 02:19:38PM -0500, Eric Sandeen wrote: > From: Eric Sandeen <sandeen@redhat.com> > > Under some circumstances we may encounter a filesystem error on a > read-only block device, and if we try to save the error info to the > superblock and commit it, we'll wind up with a noisy error and > backtrace, i.e.: > > [ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode # > ------------[ cut here ]------------ > generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2) > WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0 > ... > > To avoid this, commit the error info in the superblock only if the > block device is writable. > > Reported-by: Ritesh Harjani <riteshh@linux.ibm.com> > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Thanks, applied. - Ted
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 0c7c4adb664e..55392903bda5 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -372,7 +372,8 @@ static void save_error_info(struct super_block *sb, const char *func, unsigned int line) { __save_error_info(sb, func, line); - ext4_commit_super(sb, 1); + if (!bdev_read_only(sb->s_bdev)) + ext4_commit_super(sb, 1); } /*