| Message ID | 4EDEA30B.8000300@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 00beb4f..1e0c3bf 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -886,7 +886,7 @@ got: ext4_handle_sync(handle); if (insert_inode_locked(inode) < 0) { err = -EINVAL; - goto fail_drop; + goto fail_put; } spin_lock(&sbi->s_next_gen_lock); inode->i_generation = sbi->s_next_generation++; @@ -950,6 +950,7 @@ fail_drop: inode->i_flags |= S_NOQUOTA; clear_nlink(inode); unlock_new_inode(inode); +fail_put: iput(inode); brelse(inode_bitmap_bh); return ERR_PTR(err);
after 250df6ed274d767da844a5d9f05720b804240197 (fs: protect inode->i_state with inode->i_lock), insert_inode_locked() no longer returns the inode with I_NEW set on failure. However, the error handler still calls unlock_new_inode() on failure, which does a WARN_ON if I_NEW is not set, so any failure spews a lot of warnings. (We also were doing dquot_drop, etc before we had initialized the quota, that gets skipped as well) Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- V2: don't rearrange clear_nlink, and edit commit message. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html