diff mbox

[1/2] ext4: journal all modifications in ext4_xattr_set_handle

Message ID 4AF5CAF6.80308@redhat.com
State Superseded, archived
Headers show

Commit Message

Eric Sandeen Nov. 7, 2009, 7:31 p.m. UTC 
Andreas Dilger wrote:
> On 2009-11-06, at 19:33, Theodore Tso wrote:

...

>>> I'd also be interested to see the "write shadow buffer to journal"
>>> one-line patch that was discussed in the bug.
>>
>> Which patch are you referring to?
> 
> 
> In bugzilla there was a comment from Chris:
> 
>         "Eric helped prove this is the case by testing a patch that always
>          crcs and writes a stable duplicate of the metadata buffer instead
>          of the metadata buffer itself (a one liner since the log code was
>          already setup for this)."
> 

Like this:

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index b0ab521..75dd58f 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -353,7 +353,7 @@  repeat:
  	/*
  	 * Do we need to do a data copy?
  	 */
-	if (need_copy_out && !done_copy_out) {
+	if (!done_copy_out) {
  		char *tmp;

  		jbd_unlock_bh_state(bh_in);