From patchwork Fri Sep 11 15:18:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Sandeen X-Patchwork-Id: 33467 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 85371B7067 for ; Sat, 12 Sep 2009 01:19:31 +1000 (EST) Received: by ozlabs.org (Postfix) id 6D4B1DDD1B; Sat, 12 Sep 2009 01:19:31 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 0DFD6DDD01 for ; Sat, 12 Sep 2009 01:19:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754287AbZIKPSe (ORCPT ); Fri, 11 Sep 2009 11:18:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754399AbZIKPSe (ORCPT ); Fri, 11 Sep 2009 11:18:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754287AbZIKPSd (ORCPT ); Fri, 11 Sep 2009 11:18:33 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BFIakO015115 for ; Fri, 11 Sep 2009 11:18:36 -0400 Received: from liberator.sandeen.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8BFIT8m015350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 11 Sep 2009 11:18:35 -0400 Message-ID: <4AAA6A44.90902@redhat.com> Date: Fri, 11 Sep 2009 10:18:28 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: ext4 development Subject: [PATCH] debugfs: open with EXT2_FLAG_64BITS X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Pointing debugfs from the pu branch at a large filesystem is still failing with: Filesystem too large to use legacy bitmaps while reading block bitmap We need to open with EXT2_FLAG_64BITS; I'm not sure if this should be a switch based on the size of the fs or not? But in any case the below gets things moving enough to use debugfs on a large filesystem. Signed-off-by: Eric Sandeen --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c index 3bb309f..fbebae7 100644 --- a/debugfs/debugfs.c +++ b/debugfs/debugfs.c @@ -127,7 +127,7 @@ void do_open_filesys(int argc, char **argv) int catastrophic = 0; blk64_t superblock = 0; blk64_t blocksize = 0; - int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES; + int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS; char *data_filename = 0; reset_getopt(); @@ -2148,7 +2148,7 @@ int main(int argc, char **argv) int sci_idx; const char *usage = "Usage: %s [-b blocksize] [-s superblock] [-f cmd_file] [-R request] [-V] [[-w] [-c] device]"; int c; - int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES; + int open_flags = EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS; char *request = 0; int exit_status = 0; char *cmd_file = 0;