| Message ID | 4A9ED75A.7030406@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Eric Sandeen wrote: > As Justin & Ric reported, something like this on a > 22T (sparse) bigfile: > > e2fsprogs/misc/mke2fs -E lazy_itable_init=1 \ > -O uninit_bg -b 4096 bigfile > mount -o loop bigfile mnt/ > for I in `seq 1 5`; do mkdir mnt/$I; done > umount mnt/ > e2fsprogs/e2fsck/e2fsck -f bigfile > > would give us corrupted block group checksums: > > <other problems related to uninit snipped> > One or more block group descriptor checksums are invalid. Fix<y>? yes > > Group descriptor 6301 checksum is invalid. FIXED. > Group descriptor 7799 checksum is invalid. FIXED. > > There wer=re a few places which accessed bg_flags directly > rather than using the helper functions; fixing these seems > to resolve the problem. Well, it resolves that problem, but further testing reveals another lurking behind it, so expect more patches ;) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 2, 2009 at 2:15 PM, Eric Sandeen<sandeen@redhat.com> wrote: > Well, it resolves that problem, but further testing reveals another > lurking behind it, so expect more patches ;) Thanks for the update. :) My test just finished with, unfortunately, the same results. -Justin -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: e2fsprogs/e2fsck/pass2.c =================================================================== --- e2fsprogs.orig/e2fsck/pass2.c +++ e2fsprogs/e2fsck/pass2.c @@ -987,12 +987,12 @@ out_htree: * we could call a function in pass1.c that checks the * newly visible inodes. */ - if (fs->group_desc[group].bg_flags & EXT2_BG_INODE_UNINIT) { + if (ext2fs_bg_flag_test(fs, group, EXT2_BG_INODE_UNINIT)) { pctx.num = dirent->inode; if (fix_problem(ctx, PR_2_INOREF_BG_INO_UNINIT, &cd->pctx)){ - fs->group_desc[group].bg_flags &= - ~EXT2_BG_INODE_UNINIT; + ext2fs_bg_flags_clear(fs, group, + EXT2_BG_INODE_UNINIT); ext2fs_mark_super_dirty(fs); ctx->flags |= E2F_FLAG_RESTART_LATER; } else { Index: e2fsprogs/lib/ext2fs/openfs.c =================================================================== --- e2fsprogs.orig/lib/ext2fs/openfs.c +++ e2fsprogs/lib/ext2fs/openfs.c @@ -350,11 +350,12 @@ errcode_t ext2fs_open2(const char *name, if (superblock > 1 && EXT2_HAS_RO_COMPAT_FEATURE(fs->super, EXT4_FEATURE_RO_COMPAT_GDT_CSUM)) { struct ext2_group_desc *gd; - for (i = 0, gd = fs->group_desc; i < fs->group_desc_count; - i++, gd++) { - gd->bg_flags &= ~EXT2_BG_BLOCK_UNINIT; - gd->bg_flags &= ~EXT2_BG_INODE_UNINIT; - gd->bg_itable_unused = 0; + dgrp_t group; + + for (group = 0; group < fs->group_desc_count; group++) { + ext2fs_bg_flags_clear(fs, group, EXT2_BG_BLOCK_UNINIT); + ext2fs_bg_flags_clear(fs, group, EXT2_BG_INODE_UNINIT); + fs->group_desc[group].bg_itable_unused = 0; } ext2fs_mark_super_dirty(fs); }
As Justin & Ric reported, something like this on a 22T (sparse) bigfile: e2fsprogs/misc/mke2fs -E lazy_itable_init=1 \ -O uninit_bg -b 4096 bigfile mount -o loop bigfile mnt/ for I in `seq 1 5`; do mkdir mnt/$I; done umount mnt/ e2fsprogs/e2fsck/e2fsck -f bigfile would give us corrupted block group checksums: <other problems related to uninit snipped> One or more block group descriptor checksums are invalid. Fix<y>? yes Group descriptor 6301 checksum is invalid. FIXED. Group descriptor 7799 checksum is invalid. FIXED. There wer=re a few places which accessed bg_flags directly rather than using the helper functions; fixing these seems to resolve the problem. Reported-by: Justin Maggard <jmaggard10@gmail.com> Reported-by: Ric Wheeler <rwheeler@redhat.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- Applies to the pu branch -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html