diff mbox series

[06/13] ext4: remove redundant check of count

Message ID 20230629120044.1261968-7-shikemeng@huaweicloud.com
State Superseded
Headers show
Series fixes and cleanups to ext4 resize | expand

Commit Message

Kemeng Shi June 29, 2023, noon UTC
Remove zero check of count which is always non-zero.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/resize.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

Comments

Theodore Ts'o Aug. 16, 2023, 3:14 a.m. UTC | #1
On Thu, Jun 29, 2023 at 08:00:37PM +0800, Kemeng Shi wrote:
> Remove zero check of count which is always non-zero.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Reviewed-by: Theodore Ts'o <tytso@mit.edu>
diff mbox series

Patch

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index f2a8c24a6fbb..c14b09d48679 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -699,16 +699,14 @@  static int setup_new_flex_group_blocks(struct super_block *sb,
 			block = start;
 		}
 
-		if (count) {
-			err = set_flexbg_block_bitmap(sb, handle,
-						      flex_gd,
-						      EXT4_B2C(sbi, start),
-						      EXT4_B2C(sbi,
-							       start + count
-							       - 1));
-			if (err)
-				goto out;
-		}
+		err = set_flexbg_block_bitmap(sb, handle,
+				flex_gd,
+				EXT4_B2C(sbi, start),
+				EXT4_B2C(sbi,
+					start + count
+					- 1));
+		if (err)
+			goto out;
 	}
 
 out: