| Message ID | 20230311170949.1047958-2-shikemeng@huaweicloud.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | two cleanups for mballoc | expand |
Kemeng Shi <shikemeng@huaweicloud.com> writes: > pa_plen -> pa_len > pa_start -> pa_pstart > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > fs/ext4/mballoc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 85d5e219933f..13dce6f07fa4 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -4146,7 +4146,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, > * provide gurantee on number of contiguous blocks allocation since that > * depends upon free space left, etc). > * In case of inode pa, later we use the allocated blocks > - * [pa_start + fe_logical - pa_lstart, fe_len/size] from the preallocated > + * [pa_pstart + fe_logical - pa_lstart, fe_len/size] from the preallocated > * range of goal/best blocks [start, size] to put it at the > * ac_o_ex.fe_logical extent of this inode. > * (See ext4_mb_use_inode_pa() for more details) > @@ -4298,7 +4298,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac, > ac->ac_status = AC_STATUS_FOUND; > ac->ac_pa = pa; > > - /* we don't correct pa_pstart or pa_plen here to avoid > + /* we don't correct pa_pstart or pa_len here to avoid > * possible race when the group is being loaded concurrently > * instead we correct pa later, after blocks are marked > * in on-disk bitmap -- see ext4_mb_release_context() > -- > 2.30.0
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 85d5e219933f..13dce6f07fa4 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4146,7 +4146,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, * provide gurantee on number of contiguous blocks allocation since that * depends upon free space left, etc). * In case of inode pa, later we use the allocated blocks - * [pa_start + fe_logical - pa_lstart, fe_len/size] from the preallocated + * [pa_pstart + fe_logical - pa_lstart, fe_len/size] from the preallocated * range of goal/best blocks [start, size] to put it at the * ac_o_ex.fe_logical extent of this inode. * (See ext4_mb_use_inode_pa() for more details) @@ -4298,7 +4298,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac, ac->ac_status = AC_STATUS_FOUND; ac->ac_pa = pa; - /* we don't correct pa_pstart or pa_plen here to avoid + /* we don't correct pa_pstart or pa_len here to avoid * possible race when the group is being loaded concurrently * instead we correct pa later, after blocks are marked * in on-disk bitmap -- see ext4_mb_release_context()
pa_plen -> pa_len pa_start -> pa_pstart Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)