| Message ID | 20220923132817.1701711-1-lkundrak@v3.sk |
|---|---|
| State | Accepted |
| Headers | show |
| Series | tune2fs: print error message when closing the fs fails | expand |
On Fri, 23 Sep 2022 15:28:17 +0200, Lubomir Rintel wrote: > I encountered an I/O error on writing the superblock on a drive: > > ... > pwrite64(3, ..., 114688, 97844727808) = 114688 > fsync(3) = -1 EIO (Input/output error) > close(3) = 0 > ... > > [...] Applied, thanks! [1/1] tune2fs: print error message when closing the fs fails commit: 7c4bbd8f052af2b2be84293ddeff0d36e35b5a8f Best regards,
diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 088f87e5..d8ba4415 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -3745,5 +3745,13 @@ closefs: if (feature_64bit) convert_64bit(fs, feature_64bit); - return (ext2fs_close_free(&fs) ? 1 : rc); + + retval = ext2fs_close_free(&fs); + if (retval) { + com_err("tune2fs", retval, + _("while writing out and closing file system")); + rc = 1; + } + + return rc; }
I encountered an I/O error on writing the superblock on a drive: ... pwrite64(3, ..., 114688, 97844727808) = 114688 fsync(3) = -1 EIO (Input/output error) close(3) = 0 ... The error was silently ignored, only indicated by the exit value. Let's print an error message. The error message was taken from mke2fs in order to reuse the translations. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- misc/tune2fs.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)