From patchwork Wed Jan 26 06:31:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xin Yin X-Patchwork-Id: 1584362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=rHHIfCeF; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JkDR36cXcz9t6h for ; Wed, 26 Jan 2022 17:32:15 +1100 (AEDT) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4JkDR22Rngz4xdl for ; Wed, 26 Jan 2022 17:32:14 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4JkDR22Dc8z4xmk; Wed, 26 Jan 2022 17:32:14 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: gandalf.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=rHHIfCeF; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4JkDR14RwMz4xdl for ; Wed, 26 Jan 2022 17:32:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbiAZGcM (ORCPT ); Wed, 26 Jan 2022 01:32:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235657AbiAZGcL (ORCPT ); Wed, 26 Jan 2022 01:32:11 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47C0FC061744 for ; Tue, 25 Jan 2022 22:32:11 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id f8so20317072pgf.8 for ; Tue, 25 Jan 2022 22:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UFV9HljKMoO/Gv/RBQllZfNyG/7KSwU8sqdiwmqzVPg=; b=rHHIfCeFr9lMxN2MhwVdmuYo0GW95Tx9RS6YGi7T29U43aewRhpZKl0dwvZl3g+1Kq MpznLmqvsUUEgwFfhPZ7zVEsRWX4OTdyf6LH8b9L2usPAyWpIkr3Sy/A+5uQnEih3ZRt vyAdWk1Ua+fnKlO9EM3Ez6IGjo/HaJyRoz3lDOa4qDrI9pMjXfD87xDnxn7xKxA06sNa opACS2Ffdr8fJCNQ5Llwq/dg3lc7Mgnd/1Q7kECcpf5D1Xru9KGi9c6s41nRFucyXzTM u1KFrWsI6P/i0pNS4Rjn5eHX8jpXbLELki4LVGuOvMfw8wXoOro1JFU9tlzQOAn8i4LL KqrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UFV9HljKMoO/Gv/RBQllZfNyG/7KSwU8sqdiwmqzVPg=; b=TiNXK/FcwqnBK3Z7uSBUSmF/MaE+PVLaY6poG91hJ83uf09VXOicv/GK2lOIm+icI7 Evel7rIUh1WL7zGLDCjvXB/iknpN0jGGqD8vkIptIz3p380rnbpbeUuz1lUVGlfZdBEp muT0MjWa1ZEqSbsoIQiqIYcp0vWQJZ20iXxU+hbQ3IkKoENXSqJb9kdC1iqdxwqQV8Vr HoACcJYKkpW1aMZ/dhahVxhk2EKJq7YSZtwfJwjzWsTOHO4iItuiublo1EhdRnXQc6Nb hdlAN+dOyMKlr26sluiaTwmRa2y+wT/JWmqrBL72LzUaFIDKBE6kauGzHzRoMzt+cemo RBnw== X-Gm-Message-State: AOAM5334EZ36O2EC+wkzFPT5LJ+k5UlnbchacQ3rLTQYCjTZH7h/lFZx 1NoX1Fw/XWmUQEYvCzQmY4/LWQ== X-Google-Smtp-Source: ABdhPJwMrKHaj3UkQOIGN91HZ1jmNkH4XivVRyJXnwGPTwata5DNZ4rKGUGsq0dUjtpeBYEuPj4Lng== X-Received: by 2002:a63:f201:: with SMTP id v1mr9352021pgh.250.1643178730748; Tue, 25 Jan 2022 22:32:10 -0800 (PST) Received: from yinxin.bytedance.net ([139.177.225.244]) by smtp.gmail.com with ESMTPSA id p20sm16349824pgm.88.2022.01.25.22.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 22:32:10 -0800 (PST) From: Xin Yin To: harshadshirwadkar@gmail.com, tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Xin Yin , kernel test robot Subject: [PATCH] ext4: fix incorrect type issue during replay_del_range Date: Wed, 26 Jan 2022 14:31:46 +0800 Message-Id: <20220126063146.2302-1-yinxin.x@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org should not use fast commit log data directly, add le32_to_cpu(). Reported-by: kernel test robot Fixes: 0b5b5a62b945 ("ext4: use ext4_ext_remove_space() for fast commit replay delete range") Signed-off-by: Xin Yin Reviewed-by: Ritesh Harjani --- fs/ext4/fast_commit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index ccd2b216d6ba..488347b4c8b0 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1798,8 +1798,9 @@ ext4_fc_replay_del_range(struct super_block *sb, struct ext4_fc_tl *tl, } down_write(&EXT4_I(inode)->i_data_sem); - ret = ext4_ext_remove_space(inode, lrange.fc_lblk, - lrange.fc_lblk + lrange.fc_len - 1); + ret = ext4_ext_remove_space(inode, le32_to_cpu(lrange.fc_lblk), + le32_to_cpu(lrange.fc_lblk) + + le32_to_cpu(lrange.fc_len) - 1); up_write(&EXT4_I(inode)->i_data_sem); if (ret) { iput(inode);