| Message ID | 20211223164436.2628390-1-bigeasy@linutronix.de |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | [REPOST,REPOST] ext4: Destroy ext4_fc_dentry_cachep kmemcache on module removal. | expand |
On Thu, 23 Dec 2021 17:44:36 +0100, Sebastian Andrzej Siewior wrote: > The kmemcache for ext4_fc_dentry_cachep remains registered after module > removal. > > Destroy ext4_fc_dentry_cachep kmemcache on module removal. > > Applied, thanks! [1/1] ext4: Destroy ext4_fc_dentry_cachep kmemcache on module removal. commit: 46336e7e7275d2714f8abeb5fd62595931f8e9aa Best regards,
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 9cc55bcda6ba4..2d414dfd60cb6 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2936,6 +2936,7 @@ bool ext4_fc_replay_check_excluded(struct super_block *sb, ext4_fsblk_t block); void ext4_fc_replay_cleanup(struct super_block *sb); int ext4_fc_commit(journal_t *journal, tid_t commit_tid); int __init ext4_fc_init_dentry_cache(void); +void ext4_fc_destroy_dentry_cache(void); /* mballoc.c */ extern const struct seq_operations ext4_mb_seq_groups_ops; diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 0f32b445582ab..4665508efd778 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -2192,3 +2192,8 @@ int __init ext4_fc_init_dentry_cache(void) return 0; } + +void ext4_fc_destroy_dentry_cache(void) +{ + kmem_cache_destroy(ext4_fc_dentry_cachep); +} diff --git a/fs/ext4/super.c b/fs/ext4/super.c index b72d989b77fb6..55f2fba6a5292 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -7133,6 +7133,7 @@ static int __init ext4_init_fs(void) out: unregister_as_ext2(); unregister_as_ext3(); + ext4_fc_destroy_dentry_cache(); out05: destroy_inodecache(); out1: @@ -7159,6 +7160,7 @@ static void __exit ext4_exit_fs(void) unregister_as_ext2(); unregister_as_ext3(); unregister_filesystem(&ext4_fs_type); + ext4_fc_destroy_dentry_cache(); destroy_inodecache(); ext4_exit_mballoc(); ext4_exit_sysfs();
The kmemcache for ext4_fc_dentry_cachep remains registered after module removal. Destroy ext4_fc_dentry_cachep kmemcache on module removal. Fixes: aa75f4d3daaeb ("ext4: main fast-commit commit path") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reviewed-by: Lukas Czerner <lczerner@redhat.com> Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> Link: https://lore.kernel.org/r/20211110134640.lyku5vklvdndw6uk@linutronix.de Link: https://lore.kernel.org/r/YbiK3JetFFl08bd7@linutronix.de --- fs/ext4/ext4.h | 1 + fs/ext4/fast_commit.c | 5 +++++ fs/ext4/super.c | 2 ++ 3 files changed, 8 insertions(+)