| Message ID | 20211123101119.5112-1-lczerner@redhat.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | common/rc: set maximum label length for ext4 | expand |
On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote: > Set maximum label length for ext4 in _label_get_max() to be able to test > online file system label set/get ioctls. Some background info included in commit log would be good, e.g. ext4 didn't support get/set label ioctl but we're going to add that support in both kernel and e2fsprogs. And I noticed the kernel patch is still in review, and has no comments so far. So I'd like to wait and make sure the new ioctl will be accepted first. Thanks, Eryu > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > --- > common/rc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/common/rc b/common/rc > index 8e351f17..50d6d0bd 100644 > --- a/common/rc > +++ b/common/rc > @@ -4545,6 +4545,9 @@ _label_get_max() > f2fs) > echo 255 > ;; > + ext2|ext3|ext4) > + echo 16 > + ;; > *) > _notrun "$FSTYP does not define maximum label length" > ;; > -- > 2.31.1
On Sun, Nov 28, 2021 at 10:33:41PM +0800, Eryu Guan wrote: > On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote: > > Set maximum label length for ext4 in _label_get_max() to be able to test > > online file system label set/get ioctls. > > Some background info included in commit log would be good, e.g. ext4 > didn't support get/set label ioctl but we're going to add that support > in both kernel and e2fsprogs. > > And I noticed the kernel patch is still in review, and has no comments > so far. So I'd like to wait and make sure the new ioctl will be accepted > first. Sure, just note that the maximum label length for ext4 will be 16 with, or without the ioctls. This patch just fixes what was missing in the first place. Thanks! -Lukas > > Thanks, > Eryu > > > > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > > --- > > common/rc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/common/rc b/common/rc > > index 8e351f17..50d6d0bd 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -4545,6 +4545,9 @@ _label_get_max() > > f2fs) > > echo 255 > > ;; > > + ext2|ext3|ext4) > > + echo 16 > > + ;; > > *) > > _notrun "$FSTYP does not define maximum label length" > > ;; > > -- > > 2.31.1 >
On Sun, Nov 28, 2021 at 10:33:41PM +0800, Eryu Guan wrote: > On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote: > > Set maximum label length for ext4 in _label_get_max() to be able to test > > online file system label set/get ioctls. > > Some background info included in commit log would be good, e.g. ext4 > didn't support get/set label ioctl but we're going to add that support > in both kernel and e2fsprogs. > > And I noticed the kernel patch is still in review, and has no comments > so far. So I'd like to wait and make sure the new ioctl will be accepted > first. > > Thanks, > Eryu It's upstream now, can we have this change in so that it can be tested? Thanks! -Lukas > > > > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > > --- > > common/rc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/common/rc b/common/rc > > index 8e351f17..50d6d0bd 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -4545,6 +4545,9 @@ _label_get_max() > > f2fs) > > echo 255 > > ;; > > + ext2|ext3|ext4) > > + echo 16 > > + ;; > > *) > > _notrun "$FSTYP does not define maximum label length" > > ;; > > -- > > 2.31.1 >
On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote: > Set maximum label length for ext4 in _label_get_max() to be able to test > online file system label set/get ioctls. > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > --- > common/rc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/common/rc b/common/rc > index 8e351f17..50d6d0bd 100644 > --- a/common/rc > +++ b/common/rc > @@ -4545,6 +4545,9 @@ _label_get_max() > f2fs) > echo 255 > ;; > + ext2|ext3|ext4) > + echo 16 After reviewing the ext4 ondisk format, 16 is the correct value. Though I wonder, what actually prevents generic/492 from running on old kernels without GETLABEL support? Either way this patch is ok, so... Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > + ;; > *) > _notrun "$FSTYP does not define maximum label length" > ;; > -- > 2.31.1 >
On Mon, Jan 31, 2022 at 09:07:00AM -0800, Darrick J. Wong wrote: > On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote: > > Set maximum label length for ext4 in _label_get_max() to be able to test > > online file system label set/get ioctls. > > > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > > --- > > common/rc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/common/rc b/common/rc > > index 8e351f17..50d6d0bd 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -4545,6 +4545,9 @@ _label_get_max() > > f2fs) > > echo 255 > > ;; > > + ext2|ext3|ext4) > > + echo 16 > > After reviewing the ext4 ondisk format, 16 is the correct value. > > Though I wonder, what actually prevents generic/492 from running on old > kernels without GETLABEL support? _require_xfs_io_command "label" should take care of that. This is why I though it was no problem to get this change in early. -Lukas > > Either way this patch is ok, so... > Reviewed-by: Darrick J. Wong <djwong@kernel.org> > > --D > > > + ;; > > *) > > _notrun "$FSTYP does not define maximum label length" > > ;; > > -- > > 2.31.1 > > >
diff --git a/common/rc b/common/rc index 8e351f17..50d6d0bd 100644 --- a/common/rc +++ b/common/rc @@ -4545,6 +4545,9 @@ _label_get_max() f2fs) echo 255 ;; + ext2|ext3|ext4) + echo 16 + ;; *) _notrun "$FSTYP does not define maximum label length" ;;
Set maximum label length for ext4 in _label_get_max() to be able to test online file system label set/get ioctls. Signed-off-by: Lukas Czerner <lczerner@redhat.com> --- common/rc | 3 +++ 1 file changed, 3 insertions(+)