| Message ID | 20211028024545.10540-1-luo.penghao@zte.com.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [linux-next] ext4: Remove unused assignments | expand |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index b1933e3..9ed8a15 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1986,7 +1986,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, + ext4_ext_get_actual_len(newext)); if (unwritten) ext4_ext_mark_unwritten(ex); - eh = path[depth].p_hdr; nearex = ex; goto merge; } @@ -2015,7 +2014,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, + ext4_ext_get_actual_len(newext)); if (unwritten) ext4_ext_mark_unwritten(ex); - eh = path[depth].p_hdr; nearex = ex; goto merge; }
The eh assignment in these two places is meaningless, because the function will goto to merge, which will not use eh. The clang_analyzer complains as follows: fs/ext4/extents.c:1988:4 warning: fs/ext4/extents.c:2016:4 warning: Value stored to 'eh' is never read Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: luo penghao <luo.penghao@zte.com.cn> --- fs/ext4/extents.c | 2 -- 1 file changed, 2 deletions(-)