Message ID | 20201125002336.274045-7-ebiggers@kernel.org |
---|---|
State | Superseded |
Headers | show |
Series | Allow deleting files with unsupported encryption policy | expand |
On Nov 24, 2020, at 5:23 PM, Eric Biggers <ebiggers@kernel.org> wrote: > > From: Eric Biggers <ebiggers@google.com> > > In preparation for reducing the visibility of fscrypt_require_key() by > moving it to fscrypt_private.h, move the call to it from > fscrypt_prepare_setattr() to an out-of-line function. > > Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Andreas Dilger <adilger@dilger.ca> > --- > fs/crypto/hooks.c | 8 ++++++++ > include/linux/fscrypt.h | 11 +++++++++-- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/fs/crypto/hooks.c b/fs/crypto/hooks.c > index 82f351d3113a..1c16dba222d9 100644 > --- a/fs/crypto/hooks.c > +++ b/fs/crypto/hooks.c > @@ -120,6 +120,14 @@ int __fscrypt_prepare_readdir(struct inode *dir) > } > EXPORT_SYMBOL_GPL(__fscrypt_prepare_readdir); > > +int __fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr) > +{ > + if (attr->ia_valid & ATTR_SIZE) > + return fscrypt_require_key(d_inode(dentry)); > + return 0; > +} > +EXPORT_SYMBOL_GPL(__fscrypt_prepare_setattr); > + > /** > * fscrypt_prepare_setflags() - prepare to change flags with FS_IOC_SETFLAGS > * @inode: the inode on which flags are being changed > diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h > index 8cbb26f55695..b20900bb829f 100644 > --- a/include/linux/fscrypt.h > +++ b/include/linux/fscrypt.h > @@ -243,6 +243,7 @@ int __fscrypt_prepare_rename(struct inode *old_dir, struct dentry *old_dentry, > int __fscrypt_prepare_lookup(struct inode *dir, struct dentry *dentry, > struct fscrypt_name *fname); > int __fscrypt_prepare_readdir(struct inode *dir); > +int __fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr); > int fscrypt_prepare_setflags(struct inode *inode, > unsigned int oldflags, unsigned int flags); > int fscrypt_prepare_symlink(struct inode *dir, const char *target, > @@ -543,6 +544,12 @@ static inline int __fscrypt_prepare_readdir(struct inode *dir) > return -EOPNOTSUPP; > } > > +static inline int __fscrypt_prepare_setattr(struct dentry *dentry, > + struct iattr *attr) > +{ > + return -EOPNOTSUPP; > +} > + > static inline int fscrypt_prepare_setflags(struct inode *inode, > unsigned int oldflags, > unsigned int flags) > @@ -840,8 +847,8 @@ static inline int fscrypt_prepare_readdir(struct inode *dir) > static inline int fscrypt_prepare_setattr(struct dentry *dentry, > struct iattr *attr) > { > - if (attr->ia_valid & ATTR_SIZE) > - return fscrypt_require_key(d_inode(dentry)); > + if (IS_ENCRYPTED(d_inode(dentry))) > + return __fscrypt_prepare_setattr(dentry, attr); > return 0; > } > > -- > 2.29.2 > Cheers, Andreas
diff --git a/fs/crypto/hooks.c b/fs/crypto/hooks.c index 82f351d3113a..1c16dba222d9 100644 --- a/fs/crypto/hooks.c +++ b/fs/crypto/hooks.c @@ -120,6 +120,14 @@ int __fscrypt_prepare_readdir(struct inode *dir) } EXPORT_SYMBOL_GPL(__fscrypt_prepare_readdir); +int __fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr) +{ + if (attr->ia_valid & ATTR_SIZE) + return fscrypt_require_key(d_inode(dentry)); + return 0; +} +EXPORT_SYMBOL_GPL(__fscrypt_prepare_setattr); + /** * fscrypt_prepare_setflags() - prepare to change flags with FS_IOC_SETFLAGS * @inode: the inode on which flags are being changed diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h index 8cbb26f55695..b20900bb829f 100644 --- a/include/linux/fscrypt.h +++ b/include/linux/fscrypt.h @@ -243,6 +243,7 @@ int __fscrypt_prepare_rename(struct inode *old_dir, struct dentry *old_dentry, int __fscrypt_prepare_lookup(struct inode *dir, struct dentry *dentry, struct fscrypt_name *fname); int __fscrypt_prepare_readdir(struct inode *dir); +int __fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr); int fscrypt_prepare_setflags(struct inode *inode, unsigned int oldflags, unsigned int flags); int fscrypt_prepare_symlink(struct inode *dir, const char *target, @@ -543,6 +544,12 @@ static inline int __fscrypt_prepare_readdir(struct inode *dir) return -EOPNOTSUPP; } +static inline int __fscrypt_prepare_setattr(struct dentry *dentry, + struct iattr *attr) +{ + return -EOPNOTSUPP; +} + static inline int fscrypt_prepare_setflags(struct inode *inode, unsigned int oldflags, unsigned int flags) @@ -840,8 +847,8 @@ static inline int fscrypt_prepare_readdir(struct inode *dir) static inline int fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr) { - if (attr->ia_valid & ATTR_SIZE) - return fscrypt_require_key(d_inode(dentry)); + if (IS_ENCRYPTED(d_inode(dentry))) + return __fscrypt_prepare_setattr(dentry, attr); return 0; }