From patchwork Sat Feb 14 08:07:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugme-daemon@bugzilla.kernel.org X-Patchwork-Id: 23143 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DB2A6DDDA2 for ; Sat, 14 Feb 2009 19:08:09 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbZBNIII (ORCPT ); Sat, 14 Feb 2009 03:08:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751251AbZBNIII (ORCPT ); Sat, 14 Feb 2009 03:08:08 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58079 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbZBNIIH (ORCPT ); Sat, 14 Feb 2009 03:08:07 -0500 Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n1E87XPL003978 for ; Sat, 14 Feb 2009 00:07:35 -0800 Received: by picon.linux-foundation.org (Postfix, from userid 65534) id 99D5311D10A; Sat, 14 Feb 2009 00:07:33 -0800 (PST) Subject: [Bug 12579] ext4 filesystem hang In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: ext4 To: linux-ext4@vger.kernel.org From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090214080733.99D5311D10A@picon.linux-foundation.org> Date: Sat, 14 Feb 2009 00:07:33 -0800 (PST) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-Spam-Status: No, hits=-3.283 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org http://bugzilla.kernel.org/show_bug.cgi?id=12579 ------- Comment #12 from aneesh.kumar@linux.vnet.ibm.com 2009-02-14 00:07 ------- On Fri, Feb 13, 2009 at 02:06:06PM -0800, bugme-daemon@bugzilla.kernel.org wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=12579 > > > > > > ------- Comment #8 from sandeen@redhat.com 2009-02-13 14:06 ------- > Created an attachment (id=20238) --> (http://bugzilla.kernel.org/attachment.cgi?id=20238&action=view) > --> (http://bugzilla.kernel.org/attachment.cgi?id=20238&action=view) > Tested patch > > Patch from Aneesh, un-whitespace-mangled. > > Ted, can you push this out? Works great. :) We might want to ask the other > reporter of something similar (next-20090206: deadlock on ext4) to test it too. > I'll ping him. > I think this small changes is also needed. diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index f743524..c80e038 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2495,7 +2495,10 @@ static int ext4_da_writepages(struct address_space *mapping, wbc->range_end = LLONG_MAX; wbc->range_cyclic = 0; range_cyclic = 1; - cycled = 0; + if (index == 0) + cycled = 1; + else + cycled = 0; } else index = wbc->range_start >> PAGE_CACHE_SHIFT;